fix(rotation): fix lint (RET507) for Spiteful Spirit fix - #237
Merged
Merged
Conversation
…ng DamageCastFinder when UnholyBurst effect exists - Per EI: DamageCastFinder disabled when effect data exists (UsingDisableWithEffectData) - Only emit via EffectCastFinder on UnholyBurst effect with DesertShroud/related hit checks - Fixes 31 Spiteful Spirit FAILs (over-generation) Signed-off-by: Roland Salardon <r.salardon@gmail.com>
…n UnholyBurst effect exists globally EI uses two finders for Spiteful Spirit: 1. DamageCastFinder (skill 29560) - disabled via UsingDisableWithEffectData when effect data exists 2. EffectCastFinder for UnholyBurst effect (C4E8DD3234E0C647993857940ED79AC1) This fix: - Disables the DamageCastFinder path when ANY UnholyBurst effect exists in the fight - Implements proper DesertShroud check (skill 40052, remove_all, 50ms window) in EffectEvent handler - Implements related hit check (skill 38767, 10ms window) for UnholyBurst Reduces rotation diffs from 132 to 129 (removes 31 Spiteful Spirit FAILs). Signed-off-by: Roland Salardon <r.salardon@gmail.com>
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes lint issues from Spiteful Spirit (29560) fix:
Fixes lint errors introduced in commit 5d5ea53.