chore(ei-parity): empty known-deltas registry + fix anonymous deadCount parity - #238
Merged
Merged
Conversation
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
…instance
EI groups every anonymous agent sharing an instance into one Non Squad
Player entity, so deaths sourced by any of them count toward the kept
first agent. The static player_agent_ids fallback bailed to {agent.id}
whenever a named agent recycled the instance, dropping the other
anonymous agents' deaths. Un-skip the deadCount parity test that
asserts this.
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the ei-parity certification cleanup that was stranded in the closed #232/#234 branches.
Commit 1 — chore(ei-parity): empty known-deltas registry
Restores
known-deltas.jsonto the spec-defined end state (story 2 'Normaliser le rapport de certification': schema v1, registre vide, les écarts sont FAIL). The 31 rules held private account names (krill le faucheur.1679, etc.) which violate the certification's no-private-data-in-versioned-artifacts constraint.Commit 2 — fix(ei-compare): aggregate deadCount for anonymous agents sharing an instance
EI groups every anonymous agent sharing an instance into one Non Squad Player entity. The static
player_agent_idsfallback returned{agent.id}whenever a named agent recycled the instance, dropping the other anonymous agents' deaths (actual=1 vs expected=2). Un-skips the previously skipped deadCount parity test.