fix(rotation): Berserk end skill (-41) on full buff removal - #240
Merged
Merged
Conversation
EI books `BerserkEndSkill` (-41) when the Berserk buff (29502) is fully removed via `remove_all`. - Added `29502: -41` to `_BUFF_LOSS_CASTS` - Added `29502` to `_BUFF_LOSS_REMOVE_ALL_ONLY` (remove_all is the only trigger) - Added `kind == "apply"` guard to `_BUFF_GAIN_SELF_ONLY` branch to avoid matching remove_all - Test: `test_berserk_loss_is_booked_as_berserk_end` Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Roddygithub
force-pushed
the
fix/berserk-end-skill
branch
from
August 16, 2026 14:28
04832cf to
4261934
Compare
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(rotation): Berserk end skill (-41) on full buff removal
EI books
BerserkEndSkill(-41) when the Berserk buff (29502) is fully removed viaremove_all.29502: -41to_BUFF_LOSS_CASTS29502to_BUFF_LOSS_REMOVE_ALL_ONLY(remove_all is the only trigger)kind == "apply"guard to_BUFF_GAIN_SELF_ONLYbranch to avoid matching remove_alltest_berserk_loss_is_booked_as_berserk_endSigned-off-by: Roland Salardon r.salardon@gmail.com