Skip to content

fix(parser/analytics): stack_id=0 bug, src_is_peer fix, squad filter for squad-only heals - #241

Merged
Roddygithub merged 2 commits into
mainfrom
fix/buffuptimes-ei-queue-logic
Aug 16, 2026
Merged

Roddygithub merged 2 commits into
mainfrom
fix/buffuptimes-ei-queue-logic

Conversation

@Roddygithub

Copy link
Copy Markdown
Owner

Changes

  • buff_state.py: Fix falsy bug in handling ( instead of )
  • parser.py: now matches EI exactly (only 0x80 SrcPeer bit)
  • rotation.py: Add parameter to , filter by squad membership (fallback to when squad set unavailable)
  • ei_compare.py: Pass (all player agents) to
  • test_parser.py: Update healing extension test fixture with

Testing

  • All 616 tests pass
  • Ei diff unchanged at 122 total (53 buffUptimes, 40 rotation, 11 downContribution, 6 group, 8 CC)

Notes

The squad filter and src_is_peer fixes didn't reduce diffs because:

  • Squad-only heals (13980, 71356) are cast by players who ARE in the squad, so filter doesn't exclude them
  • EI groups heals by caster and drops ALL heals from non-squad casters (group-based logic needed)
  • Remaining rotation diffs: 14413 Dolyak Signet (-5 missing, effect not emitted), 13980/71356 extra (group-based heal filtering needed)
  • buffUptimes needs QueueLogic/HealingLogic rewrite (capacity 5, front-stack presence, waste shortest)

Signed-off-by: Roland Salardon r.salardon@gmail.com

…squad-only heals

- buff_state.py: fix stack_id=0 falsy check in remove_single (event.stack_id is not None)
- parser.py: src_is_peer now matches EI EXTHealingExtensionEvent.SrcIsPeer (only 0x80 bit)
- rotation.py: add squad_agent_ids param to build_skill_rotation, filter _HEALING_CASTS_SQUAD_ONLY by squad membership (fallback to src_is_peer)
- ei_compare.py: pass squad_agent_ids (player agents) to build_skill_rotation
- test_parser.py: update healing extension test fixture with is_offcycle=0x80

Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
@Roddygithub
Roddygithub merged commit 51fe749 into main Aug 16, 2026
11 checks passed
@Roddygithub
Roddygithub deleted the fix/buffuptimes-ei-queue-logic branch August 16, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant