Repository navigation
fix(parser/analytics): stack_id=0 bug, src_is_peer fix, squad filter for squad-only heals - #241
Merged
Merged
Conversation
…squad-only heals - buff_state.py: fix stack_id=0 falsy check in remove_single (event.stack_id is not None) - parser.py: src_is_peer now matches EI EXTHealingExtensionEvent.SrcIsPeer (only 0x80 bit) - rotation.py: add squad_agent_ids param to build_skill_rotation, filter _HEALING_CASTS_SQUAD_ONLY by squad membership (fallback to src_is_peer) - ei_compare.py: pass squad_agent_ids (player agents) to build_skill_rotation - test_parser.py: update healing extension test fixture with is_offcycle=0x80 Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Notes
The squad filter and src_is_peer fixes didn't reduce diffs because:
Signed-off-by: Roland Salardon r.salardon@gmail.com