fix(buff): implement QueueLogic for single-stack duration boons - #244
Merged
Merged
Conversation
- Add QueueLogic for 11 single-stack duration boons (fury, quickness, alacrity, protection, vigor, aegis, swiftness, resistance, resolution, superspeed, stealth) with capacity 9 per Elite Insights - Only front stack counts toward uptime; overflow drops shortest duration (not front); extensions graft onto closest duration match - Refactor _advance into _advance_single, _advance_queue, _advance_intensity to reduce complexity (ruff PLR0912/PLR0915) Addresses BACKLOG: buff capacities from log (alacrity logs declare 99, was 9) and QueueLogic parity for single-stack boons. Signed-off-by: Roddy <r.salardon@gmail.com> Signed-off-by: Roddygithub <roddygithub@users.noreply.github.com>
Signed-off-by: Roddygithub <roddygithub@users.noreply.github.com>
Roddygithub
enabled auto-merge (squash)
August 18, 2026 10:06
…nsity remove_single QueueLogic apply and BuffApplyEvent stored absolute expiry (time_ms + duration_ms) while _advance_single/_advance_queue treat expirations as remaining durations, breaking fury/boon uptime tails and extension grafting. Store duration_ms directly and graft extensions by abs(remaining - old_duration). The QueueLogic refactor also replaced the intensity remove_single branch (elif event.stacks) with max_stacks==1, so might/stability removes no longer decremented stacks. Restore it, keeping the duration-fallback lookup for max_stacks==1 and index-0 for intensity. Signed-off-by: Roddy <r.salardon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Elite Insights' QueueLogic for 11 single-stack duration boons:
Refactors
_advanceinto_advance_single,_advance_queue,_advance_intensityto reduce cyclomatic complexity (ruff PLR0912/PLR0915).Addresses BACKLOG items:
All checks pass: ruff, mypy, pytest (341 tests).