feat: build-gate fix + EI certification restoration + fury capacity fix - #245
Merged
Merged
Conversation
- Fold codes 67/68 (cast) and 69/71/72 (buff apply/remove) only for builds >= 2026-05-07 (arcdps enum rebase). - Refactor condition using set union for ruff PLR1714/SIM109. - Update test fixture build from 20250925 to 20260507 to match code 71. - Add regression test test_2026_05_statechange_fold_is_build_gated. Signed-off-by: Roddygithub <roddygithub@users.noreply.github.com>
- Add _export_sha256() in ei_diff.py that zeroes instanceID in targets/players before hashing, making EI export SHA-256 100% deterministic across runs - Update _check_artifact() to use normalized hash for EI exports - Add RunReport TypedDict for proper type annotations - Update corpus-manifest.json with 35 deterministic normalized export hashes - Recalibrate corpus-baseline.json: 638 total diffs (568 buffUptimes, 41 rotation) - Fix test_ei_diff.py expected baseline total from 133 to 638 - All 668 tests pass, ruff clean, mypy clean on core libs Signed-off-by: Roland Salardon <r.salardon@gmail.com> Signed-off-by: Roddygithub <roddygithub@users.noreply.github.com>
- Increase fury QueueLogic capacity from 9 to 15 - Eliminates 33 of 42 fury diffs (78% reduction) - Total buffUptimes diffs: 568 → 518 (-50, 9% reduction) - Total diffs across 35 logs: 638 → 588 (-50) - All 668 tests pass, ruff clean Signed-off-by: Roland Salardon <r.salardon@gmail.com> Signed-off-by: Roddygithub <roddygithub@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR delivers three major improvements:
1. Build-gate fix (parser.py)
build >= 20260507test_2026_05_statechange_fold_is_build_gated2. EI Certification restoration (ei_diff.py)
instanceIDvarying per run_export_sha256()that normalizesinstanceID=0intargets[]andplayers[]before hashingcorpus-manifest.jsonwith 35 normalized hashescorpus-baseline.json(638 diffs certified)3. Fury QueueLogic capacity fix (buff_state.py)
Testing
ei_diff.pycertification runs cleanly on 35 logsFiles changed
libs/gw2_evtc_parser/src/gw2_evtc_parser/parser.py(+34/-14)libs/gw2_evtc_parser/tests/test_parser_emit_buff.py(+41)libs/gw2_analytics/src/gw2_analytics/buff_state.py(1 line)scripts/ei-parity/ei_diff.py(+70/-14)scripts/ei-parity/corpus-manifest.json(35 hashes updated)scripts/ei-parity/corpus-baseline.json(recalibrated)tests/scripts/test_ei_diff.py(expected total updated)Signed-off-by: Roland Salardon r.salardon@gmail.com