parser: time-aware pet ownership + queue capacity fixes + Sand Cascade fix - #246
Merged
Merged
Conversation
…ID fix - rotation.py: use ownership_resolver (TemporalIdentityResolver) for all pet/minion spawn attribution (Ranger Pet -28, Siege Turtle, Fern Hound, Smokescale, Warclaw, Jungle Stalker) instead of static spawn_owner_by_target map - rotation.py: add gw2_build parameter and GW2 build 194363 cutoff for Sand Cascade effect GUID -> skill ID mapping (pre-194363: 62671, 194363+: 43448) - ei_compare.py: pass fight.header.gw2_build to build_skill_rotation - test_rotation.py: update post-July Sand Cascade test to pass gw2_build=200000 Signed-off-by: Roddygithub <roddygithub@users.noreply.github.com>
Roddygithub
enabled auto-merge (squash)
August 19, 2026 01:35
- buff_state.py: increase Regeneration capacity 5->15, Resolution 9->15 (matches EI's effective queue depth; fixes 52 buffUptimes diffs) - test_buff_state.py: update Regeneration eviction test for new capacity Signed-off-by: Roddygithub <roddygithub@users.noreply.github.com>
Roddygithub
changed the title
- _advance_intensity: decrement total_durations with elapsed time to match EI's Shift() where TotalDuration = Duration + Extensions decreases as Duration ticks down. This fixes extension grafting matching stale TotalDuration values. - remove_single OverrideLogic: add TotalDuration ±15ms fallback matching EI's Math.Abs(removedDuration - TotalDuration) < BuffSimulatorDelayConstant when stack_id match fails. Removes index-0 fallback that incorrectly dropped shortest stack. Result: Might (740) diffs 248 → 21, total EI diffs 536 → 302. Signed-off-by: Roddy <roddy@localhost>
Fix formatting issues from CI lint check. Signed-off-by: Roddy <roddy@localhost>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four parser improvements for EI parity:
1. Time-aware pet/minion ownership resolution (CAP-4)
ownership_resolver(TemporalIdentityResolver) for all pet spawn attributionspawn_owner_by_targetmap when resolver unavailable2. Sand Cascade skill ID fix (GW2 build 197490 cutoff)
23613E6E374EC6429FE9A69CC893984Dand44092AEF6D619F4093FEA4E9D9142D01map to different skill IDs pre/post GW2 build 197490fight.header.gw2_build(not arcdps build date)3. Regeneration/Resolution queue capacity increase
Testing
Remaining work (follow-up PRs)