fix(buff_state): QueueLogic overflow replaces in place + honor added_active - #248
Merged
Merged
Conversation
Roddygithub
force-pushed
the
fix/queue-logic-in-place
branch
from
August 20, 2026 10:36
fdd518c to
6f88500
Compare
…active EI QueueLogic.FindLowestValue replaces the shortest non-front stack in place (stacks[IndexOf(toRemove)] = toAdd), preserving queue order. The port popped the victim and appended at the end, rotating the queue and changing which stack fronts next. Align the mid-combat apply path, and honor added_active on both apply paths (EI BuffSimulator.Add calls _logic.Activate, moving the stack to the front). Signed-off-by: Roddy
Roddygithub
force-pushed
the
fix/queue-logic-in-place
branch
from
September 18, 2026 17:43
6f88500 to
d4836e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EI QueueLogic.FindLowestValue replaces the shortest non-front stack in place (stacks[IndexOf(toRemove)] = toAdd), preserving queue order. The port popped the victim and appended at the end, rotating the queue and changing which stack fronts next.
Aligns the mid-combat apply path, and honors added_active on both apply paths (EI BuffSimulator.Add calls _logic.Activate, moving the stack to the front).
Tests: 2 new regression tests; 344 passed, ruff + mypy clean.