This repository was archived by the owner on Oct 11, 2026. It is now read-only.
Repository navigation
ci: enforce branch protection on main and reconcile CI docs - #316
Merged
Merged
Conversation
- Apply classic branch protection: 9 required status checks, PR required, linear history, no force push/deletion, enforce_admins - ci.yml: CONTRIBUTING lists 9 required checks, not 6; dco-check comment claimed informational-only although it is now a required gate - dependabot-auto-merge.yml: drop dangling plans/136 + plans/137 refs (those plans are an arcdps sidecar and a buff-uptime model) - CONTRIBUTING.md: record that the ruleset is applied and via which API - CHANGELOG.md: document the gap and the smoke-test validation Signed-off-by: Roland Salardon <r.salardon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Met en place la protection de branche que
CONTRIBUTING.mddocumente depuis le flip public, et réconcilie les docs qui la décrivaient comme déjà active alors qu'elle ne l'était pas.Pourquoi
Sur
main,required_status_checksétaitnull: aucun check requis, aucune review requise. Résultat, le 01/10 : 4 PR dependabot mergeées en moins de 30 s dont une dont la CI était rouge —dependabot-auto-mergeappellegh pr merge --auto --squash, et sans exigence de branche « auto » = immédiat.Cause racine : la checklist du retournement public (
CONTRIBUTING.md§ Public-flip cheatsheet) se termine par une étape manuelle :Elle n'a jamais été exécutée, pendant que CHANGELOG, CONTRIBUTING et
ci.ymlécrivaient tous « themainruleset » au présent.Ce qui est appliqué
Via l'API de branch protection classique (
gh rulesetest Enterprise-only) :enforce_adminsPlaywright (visual-regression)reste hors liste :continue-on-error: true+ baselines pré-v0.16.x, comme documenté.Validation
BLOCKEDà chaque poll pendant que les checks tournent →CLEANà 10/10 → merge OK.mainrefusé :GH006: Changes must be made through a pull request+9 of 9 required status checks are expected.Corrections de doc
ci.yml: « CONTRIBUTING lists 6 required-status-checks » → 9 ; le commentaire du jobdco-checkdisait encore « NOT currently added … informational-only » alors qu'il est maintenant requis.dependabot-auto-merge.yml: les renvoisplans/136etplans/137pointaient vers arcdps healing stats sidecar et buff uptime Pydantic model — aucun rapport avec la CI, et les fichiers ne sont même pas dans l'arbre.CONTRIBUTING.md: la section passe de « Recommended » à « Status: applied », avec l'endpoint exact pour la réappliquer.CHANGELOG.md: entrée[Unreleased]qui documente le trou et la validation.