Repository navigation
fix(api): display profession names, cross-validate elite specs, tune role detection - #72
Merged
Merged
Conversation
…e role detection Signed-off-by: Roddy GitHub <roddy@users.noreply.github.com>
…output Signed-off-by: Roddy GitHub <roddy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes for profession/elite spec/role display accuracy:
1. Profession names in UI (route_helpers.py)
format_profession()returns "Guardian", "Warrior", etc. instead of "PROF(2)".2. Elite spec cross-validation (parser.py)
New
_validate_elite_for_profession()rejects elite specs that dont belong to the parsed profession (e.g. Warrior with elite=74 → Virtuoso). Degrades to BASE; raw value preserved inelite_raw.3. Role detection tuning (role_detection.py)
_R_HEAL_OVERRIDEraised 0.15→0.30 so low-healing healer-spec players arent falsely tagged Heal.