Skip to content

fix(parser): update elite spec IDs to match GW2 v2 API + add Visions of Eternity specs - #73

Merged
Roddygithub merged 1 commit into
mainfrom
fix/elite-spec-api-ids
Jul 24, 2026
Merged

Roddygithub merged 1 commit into
mainfrom
fix/elite-spec-api-ids

Conversation

@Roddygithub

Copy link
Copy Markdown
Owner

Summary

The EliteSpec enum and _VALID_ELITE_BY_PROFESSION validation dict used outdated integer IDs that did not match the official GW2 v2 API. EVTC2025+ logs write the API IDs natively, causing all Visions of Eternity elite specializations (and several older specs) to display as UNKNOWN/BASE.

Changes

libs/gw2_core/models.py — EliteSpec enum rewritten with the correct 36 IDs from the GW2 v2 API (/v2/specializations?ids=all). Fixed 10 wrong IDs (Daredevil, Weaver, Deadeye, Spellbreaker, Harbinger, Virtuoso, Catalyst, Vindicator, Specter, Untamed). Added 10 missing specs: Bladesworn(68), Troubadour(73), Paragon(74), Amalgam(75), Ritualist(76), Antiquary(77), Galeshot(78), Conduit(79), Evoker(80), Luminary(81).

libs/gw2_evtc_parser/parser.py —

  • _VALID_ELITE_BY_PROFESSION updated with API IDs
  • New _LEGACY_ELITE_OVERRIDE dict for backward compat with pre-2025 logs
  • Legacy _decode_agent skips cross-validation (API IDs differ from old arcdps IDs)
  • EVTC2025+ _decode_agent_2025 keeps cross-validation (raw IDs match API)

Validation

  • ✅ 543 lib tests + 169 API tests pass
  • ✅ Real 48-player WvW log: 45 elite specs correctly detected, 0 UNKNOWN with non-zero raw
  • ✅ All 9 Visions of Eternity specs (Luminary, Paragon, etc.) detected correctly
  • ✅ Legacy Daredevil/Soulbeast collision (55) and Weaver/Renegade collision (63) still handled

…of Eternity specs

Signed-off-by: Roddy GitHub <roddy@users.noreply.github.com>
@Roddygithub
Roddygithub force-pushed the fix/elite-spec-api-ids branch from 1d83463 to 85884d2 Compare July 24, 2026 22:00
@Roddygithub
Roddygithub merged commit 54a7e52 into main Jul 24, 2026
11 checks passed
@Roddygithub
Roddygithub deleted the fix/elite-spec-api-ids branch July 24, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants