Repository navigation
fix(parser): update elite spec IDs to match GW2 v2 API + add Visions of Eternity specs - #73
Merged
Merged
Conversation
…of Eternity specs Signed-off-by: Roddy GitHub <roddy@users.noreply.github.com>
Roddygithub
force-pushed
the
fix/elite-spec-api-ids
branch
from
July 24, 2026 22:00
1d83463 to
85884d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
EliteSpecenum and_VALID_ELITE_BY_PROFESSIONvalidation dict used outdated integer IDs that did not match the official GW2 v2 API. EVTC2025+ logs write the API IDs natively, causing all Visions of Eternity elite specializations (and several older specs) to display as UNKNOWN/BASE.Changes
libs/gw2_core/models.py — EliteSpec enum rewritten with the correct 36 IDs from the GW2 v2 API (
/v2/specializations?ids=all). Fixed 10 wrong IDs (Daredevil, Weaver, Deadeye, Spellbreaker, Harbinger, Virtuoso, Catalyst, Vindicator, Specter, Untamed). Added 10 missing specs: Bladesworn(68), Troubadour(73), Paragon(74), Amalgam(75), Ritualist(76), Antiquary(77), Galeshot(78), Conduit(79), Evoker(80), Luminary(81).libs/gw2_evtc_parser/parser.py —
_VALID_ELITE_BY_PROFESSIONupdated with API IDs_LEGACY_ELITE_OVERRIDEdict for backward compat with pre-2025 logs_decode_agentskips cross-validation (API IDs differ from old arcdps IDs)_decode_agent_2025keeps cross-validation (raw IDs match API)Validation