This repository was archived by the owner on Oct 11, 2026. It is now read-only.
Repository navigation
test: add CompareReadoutTable component tests (15 tests) - #76
Merged
Merged
Conversation
- Covers all 4 table types (damage, heal, boons, defense) - Empty state for each table type - Player data rendering with DPS/Heal bars - Boon uptime percentages and outgoing values - 14 official GW2 boon icons in header - Default sort order (dps_total desc, hps desc, etc.) - Identity cells (subgroup, name, roles) - Column headers for all table types Signed-off-by: RoddyGitHub <roddy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changements
Ajout de 15 tests pour le composant
CompareReadoutTable(tables HTML natives de la page/fights/compare).Couverture
Validation
Ferme le gap de couverture laissé par la suppression des tests AG Grid dans PR #75.