refactor: simplify parser.py elite validation + extract shared test fixture - #77
Merged
Merged
Conversation
…ixture
- parser.py: removed empty _LEGACY_ELITE_OVERRIDE={} dict and collapsed two-branch
elite validation in _decode_agent (both branches produced identical results
since the override dict was always identity).
- Created web/tests/fixtures/playerReadoutRow.ts with buildPlayerReadoutRow()
— shared PlayerReadoutOut test fixture (zero defaults).
- PlayerReadoutCells.test.tsx: replaced local makeRow() with import from shared fixture.
- compare-readout-table.test.tsx: replaced local buildRow() with wrapper
around shared fixture that adds nonzero defaults.
Signed-off-by: RoddyGitHub <roddy@users.noreply.github.com>
Added missing blank line between docstring summary and first paragraph. Signed-off-by: RoddyGitHub <roddy@users.noreply.github.com>
Signed-off-by: RoddyGitHub <roddy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changements\n\n### parser.py\n- Suppression du dictionnaire vide
_LEGACY_ELITE_OVERRIDE = {}\n- Simplification de la validation élite dans_decode_agent: les deux branches\n produisaient le même résultat puisque le dictionnaire était toujours identité\n\n### Fixture partagée\n- Création deweb/tests/fixtures/playerReadoutRow.tsavecbuildPlayerReadoutRow()\n- PlayerReadoutCells.test.tsx : importe depuis la fixture partagée (43 tests)\n- compare-readout-table.test.tsx : wrapper autour de la fixture partagée (15 tests)\n\n### Validation\n- TypeScript clean\n- 58 tests vitest passent\n- Tous les tests Python passent