Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
137 commits
Select commit Hold shift + click to select a range
f2d5415
Fix part of #24933: Add validation checks for metadata translations
Rohan-Unbeg Jul 12, 2026
fd502ac
Fix translation metadata suggestion creation and reviewer listing val…
Rohan-Unbeg Jul 14, 2026
dab7f5a
Fix language_code mismatch in metadata translation validation test
Rohan-Unbeg Jul 14, 2026
a3a35fd
Add code owner review comment explaining generic metadata suggestion …
Rohan-Unbeg Jul 15, 2026
02b9634
Make Skill domain object inherit from BaseTranslatableObject and impl…
Rohan-Unbeg Jul 15, 2026
81a3eea
Merge remote-tracking branch 'upstream/develop' into gsoc-task-2.1
Rohan-Unbeg Jul 16, 2026
d23e879
Address review comments: Define and use constants for exploration met…
Rohan-Unbeg Jul 16, 2026
c208208
Address review comments: Fix TS strict type checks and add 100% unit …
Rohan-Unbeg Jul 16, 2026
12281ee
Document UX sorting decision for exploration metadata translation cards
Rohan-Unbeg Jul 18, 2026
b1f42be
Update translation cards sorting logic to prepend metadata cards per …
Rohan-Unbeg Jul 21, 2026
bed3963
Address review: Use specific ContentTypes and matching content IDs fo…
Rohan-Unbeg Jul 22, 2026
cfe73ba
Address review: Use constants for metadata content types and IDs
Rohan-Unbeg Jul 23, 2026
f78f140
Order generic metadata cards first in TranslatableTexts.createFromBac…
Rohan-Unbeg Jul 23, 2026
e07793f
Fix feature-flagged acceptance tests for V2 metadata cards order
Rohan-Unbeg Jul 24, 2026
0f888d1
Fix feature-flagged acceptance tests by skipping Category metadata card
Rohan-Unbeg Jul 25, 2026
707d242
Fix acceptance test failure by restoring 'Save and close' button clic…
Rohan-Unbeg Jul 25, 2026
022ed1a
Fix part of #24933: Implement skill translation opportunity lifecycle…
Rohan-Unbeg Jul 25, 2026
ca90e7e
Merge branch 'develop' into gsoc-task-2.1
Rohan-Unbeg Jul 25, 2026
c08f6b1
Fix acceptance tests by removing obsolete closeTranslateTextModal cal…
Rohan-Unbeg Jul 26, 2026
d23e22e
Merge branch 'gsoc-task-2.1' of https://github.com/rohan-Unbeg/oppia …
Rohan-Unbeg Jul 26, 2026
8974c4e
Fix UnboundLocalError and NoneType error in create_suggestion for non…
Rohan-Unbeg Jul 26, 2026
0472417
Fix topic deletion opportunity cleanup and add missing unit test cove…
Rohan-Unbeg Jul 26, 2026
6533c5e
Address review comment: Update spec comment for final card save and c…
Rohan-Unbeg Jul 28, 2026
317ac61
Address review comments for PR 2.3: refactor skill opportunity lifecy…
Rohan-Unbeg Jul 29, 2026
a73cf18
Fix part of #24933: Display translated exploration metadata
Rohan-Unbeg Jul 29, 2026
001cc41
Fix pylint re-import warning in library_test and summary_services_test
Rohan-Unbeg Jul 29, 2026
40ed425
Add translation opportunity in test_update_skill to cover skill oppor…
Rohan-Unbeg Jul 29, 2026
6a3152e
Add unit test coverage for translated exploration category and tags i…
Rohan-Unbeg Jul 29, 2026
5cb27d3
Merge branch 'upstream/develop' into gsoc-task-2.3
Rohan-Unbeg Jul 29, 2026
d7fb3e5
Add unit test for updating v2 translation opportunity on skill change
Rohan-Unbeg Jul 30, 2026
5403401
Merge branch 'upstream/develop' into gsoc-task-2.3
Rohan-Unbeg Jul 30, 2026
1aeef78
Merge upstream/develop into gsoc-task-2.7
Rohan-Unbeg Jul 30, 2026
de0c496
Update skill opportunity lifecycle per Sean's decisions
Rohan-Unbeg Jul 30, 2026
f58534f
Merge branch 'develop' into gsoc-task-2.3
Rohan-Unbeg Aug 1, 2026
8a73bca
Merge branch 'develop' into gsoc-task-2.7
Rohan-Unbeg Aug 1, 2026
96bbb5b
Merge upstream/develop into gsoc-task-2.3
Rohan-Unbeg Aug 1, 2026
c974251
Fix black formatting and merge develop into gsoc-task-2.3
Rohan-Unbeg Aug 1, 2026
2f0e617
Merge remote-tracking branch 'origin/gsoc-task-2.3' into gsoc-task-2.3
Rohan-Unbeg Aug 1, 2026
5eeb5e9
Fix pylint and black formatting issue in test_utils.py
Rohan-Unbeg Aug 1, 2026
6ea1d46
Format test_utils.py with black
Rohan-Unbeg Aug 2, 2026
fac1ab8
Address review comments for PR 2.3: enhance test assertions and skill…
Rohan-Unbeg Aug 3, 2026
a12ee81
Fix pylint unused import and add unit test for skill content mismatch…
Rohan-Unbeg Aug 3, 2026
f0bd341
Merge remote-tracking branch 'upstream/develop' into gsoc-task-2.3
Rohan-Unbeg Aug 3, 2026
adf49c6
Fix part of #24933: Update controllers for skill translations
Rohan-Unbeg Aug 3, 2026
8893f7d
Fix part of #24933: Add entity-type-selector frontend component for s…
Rohan-Unbeg Aug 3, 2026
8d27c1e
Merge upstream/develop into gsoc-task-2.5-v2
Rohan-Unbeg Aug 6, 2026
4d65da2
Merge upstream/develop into gsoc-task-2.7
Rohan-Unbeg Aug 6, 2026
1f9060d
Clean up formatting diffs on non-PR files
Rohan-Unbeg Aug 6, 2026
38c57be
Add feature flag gating, 'All' option, and single horizontal row layo…
Rohan-Unbeg Aug 7, 2026
9186fba
Fix contributor dashboard entity type filtering and multi-entity tran…
Rohan-Unbeg Aug 7, 2026
1f56544
Fix contributor dashboard entity type filtering, admin data generator…
Rohan-Unbeg Aug 7, 2026
55a32c4
Fix mypy type annotations in opportunity_services and suggestion_serv…
Rohan-Unbeg Aug 7, 2026
e32e4c0
Merge upstream/develop and fix V2 acceptance tests, frontend specs, a…
Rohan-Unbeg Aug 8, 2026
89af4c6
Format suggestion_services_test.py with black
Rohan-Unbeg Aug 8, 2026
d21b269
Fix entity-type-selector component CSS linter error and contribution …
Rohan-Unbeg Aug 8, 2026
5aac0b1
Fix root files mapping config and translation opportunities component…
Rohan-Unbeg Aug 8, 2026
96b21cf
Fix contribution and review service spec expected fetchSuggestionsAsy…
Rohan-Unbeg Aug 8, 2026
c6e1948
Fix ReviewableOpportunitiesHandler empty topic_name parameter handlin…
Rohan-Unbeg Aug 8, 2026
2bce197
Fix contributor dashboard API payload, CSS layout, and backend coverage
Rohan-Unbeg Aug 8, 2026
2b0393e
Fix lint issues in opportunity and suggestion tests
Rohan-Unbeg Aug 9, 2026
4ad4db4
Fix CI pylint, mypy, and suggestion service unit tests for PR 2.5
Rohan-Unbeg Aug 9, 2026
e0551fb
Fix skill acceptance unit test in translation suggestion review modal…
Rohan-Unbeg Aug 9, 2026
f3c3456
Fix part of #24933: Fix review modal entity-type default, mobile tran…
Rohan-Unbeg Aug 9, 2026
1da1ade
Fix part of #24933: Fix Shard 2 backend test regex
Rohan-Unbeg Aug 9, 2026
25d9b45
Fix part of #24933: Fix spy assertion in skill acceptance test and re…
Rohan-Unbeg Aug 9, 2026
9166a07
Fix part of #24933: Give V2 translation specs their own screenshot ba…
Rohan-Unbeg Aug 10, 2026
71f731f
Fix part of #24933: Cover skill translation review paths, drop unreac…
Rohan-Unbeg Aug 10, 2026
43d48a7
Fix part of #24933: Dispatch the mobile translate-button click on the…
Rohan-Unbeg Aug 10, 2026
d7fa652
Fix part of #24933: Display translated concept cards
Rohan-Unbeg Aug 10, 2026
9b5d3d8
Revert incidental formatting changes to files outside this PR's scope
Rohan-Unbeg Aug 11, 2026
94619d0
Address review comments: take entity type from the opportunity, add a…
Rohan-Unbeg Aug 11, 2026
dbc5aeb
Move the entity type constant into the contributor dashboard constants
Rohan-Unbeg Aug 11, 2026
72187c7
Revert the duplicate entity type constant from the shared constants file
Rohan-Unbeg Aug 11, 2026
656fbc5
Merge remote-tracking branch 'upstream/develop' into gsoc-task-2.5-v2
Rohan-Unbeg Aug 11, 2026
e212083
Merge remote-tracking branch 'upstream/develop' into gsoc-task-2.5-v2
Rohan-Unbeg Aug 12, 2026
ed84d9e
Restore the invalid target type test dropped during the develop merge
Rohan-Unbeg Aug 12, 2026
7cbe80a
Translate the skill description on concept cards
Rohan-Unbeg Aug 12, 2026
dc83524
Address review: take entity type from the model and remove unused def…
Rohan-Unbeg Aug 12, 2026
a819c2e
Merge remote-tracking branch 'upstream/develop' into gsoc-task-2.5-v2
Rohan-Unbeg Aug 12, 2026
bcdecf0
Capitalize the target_type comments to satisfy the lint rule
Rohan-Unbeg Aug 13, 2026
949d8e0
Display translated exploration metadata in the learner's site language
Rohan-Unbeg Aug 13, 2026
3301b30
Merge remote-tracking branch 'upstream/develop' into gsoc-task-2.7
Rohan-Unbeg Aug 13, 2026
407ff7e
Prefer contributor translations over hardcoded i18n bundles for explo…
Rohan-Unbeg Aug 13, 2026
f814417
Resolve each opportunity's entity type once instead of in three separ…
Rohan-Unbeg Aug 13, 2026
d04ae71
[GSoC 2026] M 2.7 - Fix Karma unit tests for translation-modal and se…
Rohan-Unbeg Aug 13, 2026
12eec05
[GSoC 2026] M 2.7 - Fix parameter order in search.service.spec.ts exp…
Rohan-Unbeg Aug 13, 2026
4f9bbde
[GSoC 2026] M 2.7 - Fix mockWindow type declaration in translation-mo…
Rohan-Unbeg Aug 13, 2026
496f1e4
[GSoC 2026] M 2.7 - Fix mockWindow pathname in translation-modal.comp…
Rohan-Unbeg Aug 13, 2026
1d4fc2d
Move the up-to-date translation lookup into translation_services
Rohan-Unbeg Aug 14, 2026
e19877a
Move the hacky translation display decision into I18nLanguageCodeService
Rohan-Unbeg Aug 14, 2026
10c29ea
Merge branch 'develop' into gsoc-task-2.7
Rohan-Unbeg Aug 15, 2026
bfb7ac4
Merge branch 'develop' into gsoc-task-2.8
Rohan-Unbeg Aug 15, 2026
5cd079c
Address review: make All fetch every entity type and remove per-type …
Rohan-Unbeg Aug 15, 2026
230fa25
fix lint and make All fetch every entity type and drop per-type branc…
Rohan-Unbeg Aug 15, 2026
c9bbe7c
Fix subheading and obsolete message for skill translation suggestions
Rohan-Unbeg Aug 15, 2026
7886946
Merge remote-tracking branch 'upstream/develop' into gsoc-task-2.5-v2
Rohan-Unbeg Aug 16, 2026
b582369
Update contribution stats and badges baselines after hiding the conte…
Rohan-Unbeg Aug 17, 2026
1cc19bb
Merge remote-tracking branch 'origin/gsoc-task-2.5-v2' into gsoc-task…
Rohan-Unbeg Aug 17, 2026
fb4a83a
Merge remote-tracking branch 'origin/gsoc-task-2.7' into gsoc-task-2.11
Rohan-Unbeg Aug 17, 2026
03c2def
Merge remote-tracking branch 'origin/gsoc-task-2.8' into gsoc-task-2.11
Rohan-Unbeg Aug 17, 2026
cd1f610
Fix part of oppia#24933: Add acceptance tests for metadata and skill …
Rohan-Unbeg Aug 17, 2026
9c3ab65
Fix part of oppia#24933: Stop the content type dropdown double-toggli…
Rohan-Unbeg Aug 17, 2026
d62841f
Merge remote-tracking branch 'upstream/develop' into gsoc-task-2.11
Rohan-Unbeg Aug 25, 2026
448b396
Fix part of oppia#24933: Wait for the translation modal to load the n…
Rohan-Unbeg Aug 25, 2026
7b8e305
Fix acceptance test flakiness and timeout issues for multi-entity tra…
Rohan-Unbeg Aug 25, 2026
872e056
Fix flaky native clicks and DOM parsing race conditions in translatio…
Rohan-Unbeg Aug 25, 2026
2dd05bb
Fix part of #24933: Fix missing translate button on mobile suggestion…
Rohan-Unbeg Aug 26, 2026
c71ff85
Fix part of oppia#24933: Restore the mobile translate-button click pa…
Rohan-Unbeg Aug 26, 2026
2a62f0d
Fix part of oppia#24933: Open the first suggestion for review and wai…
Rohan-Unbeg Aug 26, 2026
2996c66
Fix part of oppia#24933: Expect the deferred review toasts in arrival…
Rohan-Unbeg Aug 26, 2026
31aa2d6
Fix part of oppia#24933: Read each review toast when the review is se…
Rohan-Unbeg Aug 26, 2026
ea89e99
Fix flakiness and timeout errors in acceptance tests for multi-entity…
Rohan-Unbeg Aug 27, 2026
33726ca
Fix flaky native clicks in acceptance test utilities
Rohan-Unbeg Aug 27, 2026
f93a848
Add missing stabilization waits to fix CI timeouts
Rohan-Unbeg Aug 28, 2026
80b32fb
Revert "Add missing stabilization waits to fix CI timeouts"
Rohan-Unbeg Aug 28, 2026
896e45f
Revert "Fix flaky native clicks in acceptance test utilities"
Rohan-Unbeg Aug 28, 2026
c5e9ed6
Fix part of #26889 and #27000: Add missing styleUrls across component…
arnav25102004 Aug 28, 2026
e8a1ae8
Fix #27040: Use native language text and lang attribute for language …
yashgamerg0026-cpu Aug 28, 2026
667d2e7
Fix #23871: Removing E2E infra and tests fully from codebase (#27149)
Mohak51234 Aug 28, 2026
aa2a3a4
Fix part of #25941: Clean up legacy embedded <style> tags from HTML t…
Aditya22-smart Aug 28, 2026
ce5030c
[GSoC 2026] M2.7- Fix part of #24716: Add the My Suggestions tab to t…
NITISH084 Aug 28, 2026
444b2c0
Upgrade lh-ci to v15 (#27071)
HardikGoyal2003 Aug 30, 2026
971af19
Fix #23033: Prevent failed emails from generating false SentEmailMode…
31puneet Aug 30, 2026
f4389d7
Address review comments: Update test descriptions to match CUJ and en…
Rohan-Unbeg Aug 31, 2026
2863a2a
Fix part of #25941: Clean up legacy embedded <style> tags from HTML t…
Aditya22-smart Aug 31, 2026
9541e00
Remove webpack infra (#27088)
Aditya22-smart Aug 31, 2026
c5a40c6
Fix added translation and question coordinators tabs (#26971)
ateeksh22 Aug 31, 2026
8130d61
Address review comment: explicitly map tests to LO.4 CUJ goal
Rohan-Unbeg Aug 31, 2026
6279919
Fix part of #25941: Clean up legacy embedded <style> tags from HTML t…
Aditya22-smart Sep 2, 2026
801487e
Split acceptance tests by user persona
Rohan-Unbeg Sep 2, 2026
dc01f78
Fix state leaks in acceptance tests caused by file splitting
Rohan-Unbeg Sep 3, 2026
348a611
Remove accidentally committed CI logs and zip files
Rohan-Unbeg Sep 3, 2026
ffcbb83
Fix N/A: Add descriptive failure messages to Playwright expectScreens…
Mohak51234 Sep 3, 2026
a8a1003
Fix typescript error for tabName in contributor.ts
Rohan-Unbeg Sep 3, 2026
7bf1454
Fix mobile click flakiness in contributor dashboard tabs
Rohan-Unbeg Sep 4, 2026
4ffde4f
Fix contributor dashboard tab click and reviewer navigation in accept…
Rohan-Unbeg Sep 4, 2026
b38016e
Merge branch 'develop' into gsoc-task-2.11
Rohan-Unbeg Sep 4, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
86 changes: 0 additions & 86 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -37,92 +37,6 @@
"oppia/no-to-throw": "error"
}
},
{
// We only run the e2e action checks on end-to-end test files, and
// we exclude files that we haven't fixed yet.
"files": [
"core/tests/webdriverio/*.js",
"core/tests/webdriverio_utils/*.js",
"core/tests/webdriverio_desktop/*.js"
],
"excludedFiles": [
"ClassroomPage.js",
"DeleteAccountPage.js",
"ExplorationEditorHistoryTab.js",
"ExplorationEditorMainTab.js",
"ExplorationEditorPage.js",
"ExplorationEditorSettingsTab.js",
"ExplorationEditorStatsTab.js",
"ExplorationEditorTranslationTab.js",
"GetStartedPage.js",
"LearnerDashboardPage.js",
"LibraryPage.js",
"ProfilePage.js",
"SkillEditorPage.js",
"StoryEditorPage.js",
"SubscriptionDashboardPage.js",
"ThanksPage.js",
"TopicAndStoryViewerPage.js",
"TopicEditorPage.js",
"TopicsAndSkillsDashboardPage.js",
"action.js",
"forms.js",
"general.js",
"users.js",
"waitFor.js",
"workflow.js",
"additionalEditorFeatures.js",
"additionalPlayerFeatures.js",
"adminTabFeatures.js",
"classroomPage.js",
"collections.js",
"contributorDashboard.js",
"coreEditorAndPlayerFeatures.js",
"creatorDashboard.js",
"embedding.js",
"explorationFeedbackTab.js",
"explorationHistoryTab.js",
"explorationImprovementsTab.js",
"explorationStatisticsTab.js",
"explorationTranslationTab.js",
"extensions.js",
"fileUploadExtensions.js",
"learnerDashboard.js",
"navigation.js",
"playVoiceovers.js",
"preferences.js",
"profileFeatures.js",
"publicationAndLibrary.js",
"skillEditor.js",
"topicAndStoryEditor.js",
"topicAndStoryEditorFileUploadFeatures.js",
"topicAndStoryViewer.js",
"topicsAndSkillsDashboard.js",
"userJourneys.js",
"voiceoverUploadFeatures.js",
"wipeout.js",
"accessibility.js",
"learnerFlow.js",
"libraryFlow.js",
"profileMenuFlow.js",
"excludedForTesting.js"
],
"rules": {
"oppia/e2e-action": "error"
}
},
{
// We only run the e2e practices checks on webdriverio
// end-to-end test files.
"files": [
"core/tests/webdriverio/*.js",
"core/tests/webdriverio_utils/*.js",
"core/tests/webdriverio_desktop/*.js"
],
"rules": {
"oppia/e2e-practices": "error"
}
},
{
// We exclude spec files from the no-testonly check
"files": ["*spec.js", "*spec.ts"],
Expand Down
4 changes: 2 additions & 2 deletions .gcloudignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ __pycache__/
# Markdown files.
*.md

# Typescript files in core and extension they are not needed as
# we compile webpack which contains these files.
# Typescript files in core and extension are not needed as
# we use the Angular CLI build which compiles these files.
core/**/*.ts
extensions/**/*.ts

Expand Down
10 changes: 1 addition & 9 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@
/core/templates/utility/hashes.ts @oppia/lace-frontend-reviewers
/core/templates/utility/string-utility*.ts @oppia/lace-frontend-reviewers
/proxy.conf.json @oppia/lace-frontend-reviewers
/angular-template-style-url-replacer.webpack-loader.js @oppia/lace-frontend-reviewers
/angular.json @oppia/lace-frontend-reviewers
/src @oppia/lace-frontend-reviewers

Expand Down Expand Up @@ -137,6 +136,7 @@
/core/domain/opportunity*.py @oppia/contributor-experience-team
/core/domain/translation*.py @oppia/contributor-experience-team
/core/templates/domain/opportunity/ @oppia/contributor-experience-team
/core/templates/domain/contributor_dashboard/ @oppia/contributor-experience-team
/core/templates/pages/contributor-dashboard-page/ @oppia/contributor-experience-team
/core/templates/pages/contributor-dashboard-admin-page/ @oppia/contributor-experience-team
/core/templates/services/html-length.service.ts @oppia/contributor-experience-team
Expand Down Expand Up @@ -741,14 +741,6 @@
/core/tests/ @oppia/dev-workflow-reviewers
/assets/ @oppia/lace-frontend-reviewers
/data/ @oppia/lace-backend-reviewers
/core/tests/webdriverio_utils/ @oppia/dev-workflow-reviewers
/core/tests/webdriverio_desktop/ @oppia/dev-workflow-reviewers
/core/tests/wdio.conf.js @oppia/dev-workflow-reviewers
/extensions/interactions/*/webdriverio.js @oppia/dev-workflow-reviewers
/extensions/interactions/webdriverio.js @oppia/dev-workflow-reviewers
/extensions/rich_text_components/*/webdriverio.js @oppia/dev-workflow-reviewers
/extensions/rich_text_components/webdriverio.js @oppia/dev-workflow-reviewers
/extensions/objects/webdriverio.js @oppia/dev-workflow-reviewers
/scripts/backend_test_shards.json @oppia/dev-workflow-reviewers
/.github/actions @oppia/dev-workflow-reviewers

Expand Down
5 changes: 2 additions & 3 deletions .github/ISSUE_TEMPLATE/3_e2e_acceptance_error_template.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: E2E or Acceptance Test CI Failure Report
name: Acceptance Test CI Failure Report
description: Create a report to help us improve
title: "[E2E/Acceptance CI Failure]: "
title: "[Acceptance CI Failure]: "
labels: [triage needed, bug, CI breakage]
body:
- type: markdown
Expand Down Expand Up @@ -33,7 +33,6 @@ body:
label: CI Test Type
description: In which CI test did this failure occur?
options:
- E2E
- Acceptance
validations:
required: true
Expand Down
7 changes: 3 additions & 4 deletions .github/ISSUE_TEMPLATE/4_ci_error_template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,14 @@ body:
attributes:
label: CI Test Type
description: >
In which CI test did this failure occur? For E2E or Acceptance test failures,
In which CI test did this failure occur? For acceptance test failures,
please use our dedicated template instead by navigating to our
[issues page](https://github.com/oppia/oppia/issues), clicking "New issue",
and selecting the template for "E2E or Acceptance Test CI Failure Report".
and selecting the template for "Acceptance Test CI Failure Report".
options:
- Frontend
- Backend
- Lighthouse CI performance
- Lighthouse CI accessibility
- Lighthouse CI
- Other
validations:
required: true
Expand Down
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,5 +96,5 @@ language set to Arabic as well (we use Arabic as it is a language written from r

- Never force push! If you do, your PR will be closed.
- To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Rules-for-making-PRs#step-5-address-review-comments-until-all-reviewers-approve
- Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the ["If your build fails" wiki page](https://github.com/oppia/oppia/wiki/If-CI-checks-fail-on-your-PR).
- Some acceptance tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the ["If your build fails" wiki page](https://github.com/oppia/oppia/wiki/If-CI-checks-fail-on-your-PR).
- See the [Code Owner's wiki page](https://github.com/oppia/oppia/wiki/Oppia's-code-owners-and-checks-to-be-carried-out-by-developers) for what code owners will expect.
5 changes: 2 additions & 3 deletions .github/actions/generate-build-files/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,15 @@ runs:
key: ${{ runner.os }}-build-files-${{ inputs.prod-env != 'false' && 'prod' || 'dev' }}-${{ github.sha }}
path: |
/home/runner/work/oppia/oppia/build
/home/runner/work/oppia/oppia/webpack_bundles
/home/runner/work/oppia/oppia/app.yaml
/home/runner/work/oppia/oppia/assets/hashes.json
/home/runner/work/oppia/oppia/dist
/home/runner/work/oppia/oppia/third_party/generated
- name: Build Webpack (prod)
- name: Build (prod)
if: steps.restore_build_files_cache.outputs.cache-hit != 'true' && inputs.prod-env != 'false'
run: python -m scripts.build --prod_env
shell: bash
- name: Build Webpack (dev)
- name: Build (dev)
if: steps.restore_build_files_cache.outputs.cache-hit != 'true' && inputs.prod-env == 'false'
run: python -c "from scripts import build; build.build_js_files(dev_mode=True)"
shell: bash
2 changes: 1 addition & 1 deletion .github/actions/run-a-specific-acceptance-test/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ runs:
# which requires all previous jobs/steps to have succeeded. This is not what we want.
# Reference: https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#status-check-functions
# Quote: "A default status check of success() is applied unless you *include* one of these functions."
if: ${{ !cancelled() && steps.run-acceptance-test.outcome == 'failure' && inputs.modified-suite-name-for-uploads != '' }}
if: ${{ !cancelled() && inputs.modified-suite-name-for-uploads != '' }}
uses: actions/upload-artifact@v4
with:
name: video-recordings_${{ inputs.modified-suite-name-for-uploads }}
Expand Down
Loading
Loading