[codex] Harden repo, add remote PR flow, and upgrade starter API#1
[codex] Harden repo, add remote PR flow, and upgrade starter API#1Rohan5commit merged 5 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR hardens the repository for remote-first workflows, adds CI validation, and upgrades the NestJS Fastify sample from a stub into a small documented API.
Changes:
- Added GitHub Actions CI for Python+shell validation and NestJS lint/build/unit/e2e tests
- Hardened local snapshot ignore rules for Modal task syncing
- Updated READMEs and the NestJS Fastify sample documentation to reflect new endpoints and workflows
Reviewed changes
Copilot reviewed 5 out of 34528 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
nestjs-fastify-boilerplate/README.md |
Replaces stock NestJS starter README with endpoint-focused documentation and usage scripts |
modal_tasks.py |
Expands ignore rules to avoid syncing common generated/cached artifacts to Modal |
README.md |
Updates repo-level docs for CLI offload and GitHub-only remote PR flow |
.github/workflows/ci.yml |
Adds CI jobs for Python/shell validation and NestJS sample testing |
.gemini/.env |
Removes committed Gemini routing env file (likely moving to local-only configuration) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| MODAL_REMOTE_REPO_URL="https://github.com/Rohan5commit/Modal-terminal-instructions.git" | ||
| MODAL_REMOTE_REPO_BRANCH="main" | ||
| MODAL_REMOTE_PUSH="1" | ||
| MODAL_REMOTE_PUSH_BRANCH="codex/my-change" | ||
| MODAL_REMOTE_OPEN_PR="1" | ||
| MODAL_REMOTE_PR_BASE="main" | ||
| MODAL_REMOTE_PR_DRAFT="1" | ||
| MODAL_REMOTE_PR_TITLE="[modal] My remote change" |
There was a problem hiding this comment.
The example config hard-codes a specific third-party repository URL, which is likely confusing/misleading for users of this repo. Recommend switching this to a placeholder (e.g., https://github.com/<org>/<repo>.git) or to this repository’s URL so the quickstart is self-contained.
|
|
||
| # test coverage | ||
| $ npm run test:cov | ||
| curl -X POST http://localhost:3000/api/compute/plan -H 'content-type: application/json' -d '{"iterations":24000000,"workers":6,"salt":23}' |
There was a problem hiding this comment.
This curl example is hard to read/copy reliably due to inline spacing and lack of line breaks. Consider formatting it across multiple lines with continuations (or at least consistent spacing) to make it more copy/paste-friendly.
| curl -X POST http://localhost:3000/api/compute/plan -H 'content-type: application/json' -d '{"iterations":24000000,"workers":6,"salt":23}' | |
| curl -X POST http://localhost:3000/api/compute/plan \ | |
| -H 'content-type: application/json' \ | |
| -d '{"iterations":24000000,"workers":6,"salt":23}' |
| - name: Install Python dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| python -m pip install modal |
There was a problem hiding this comment.
CI installs modal without pinning or a requirements lock, which can introduce non-deterministic failures as dependencies evolve. Prefer installing from a pinned requirements file (e.g., requirements.txt/requirements-dev.txt) or pinning modal==... to keep CI reproducible.
| python -m pip install modal | |
| python -m pip install modal==0.72.39 |
Summary
Validation