Skip to content

Conversation

@Jeremy-Walton
Copy link
Member

@Jeremy-Walton Jeremy-Walton commented Dec 30, 2025

Task

Fixes #302

Why?

The sidebar, navbar, and modal with dialog were a bit outdated and needed some improvement.

What Changed

  • Add new token for setting the modal transition time
  • Ensure navbar has a top border when used in the footer
  • Ensure sidebar has a left border when used on the right side
  • Update modal when used on <dialog> to greatly simplify and work better

Quality Assurance

  • Have you tagged the PR with the correct labels?
  • Have you validated the changes?
    • Have you run linters? (yarn sanity-check)
    • Have you run prettier?
    • Have you tried building the css?
    • Have you tried building storybook?
  • Have you updated any usage of changed tokens?
  • [ ] Did you add a component?
    • [ ] Have you added it to the dependency graph?
    • [ ] Have you added it to the docs?
  • Did you update a component?
    • [ ] Have you updated the dependency graph?
    • Have you updated the docs?
  • [ ] Do you need to update the package version?
    Planning on including in release v2.3.0

Screenshots

Screenshot 2025-12-30 at 3 48 09 PM Screenshot 2025-12-30 at 3 00 40 PM Screenshot 2025-12-30 at 3 41 48 PM Screenshot 2025-12-30 at 3 41 52 PM Screenshot 2025-12-30 at 3 53 34 PM

@Jeremy-Walton Jeremy-Walton added this to the v2.3.0 milestone Dec 30, 2025
@Jeremy-Walton Jeremy-Walton self-assigned this Dec 30, 2025
@Jeremy-Walton Jeremy-Walton added enhancement New feature or request Base Tokens Changes to the base tokens Components Changes to a component labels Dec 30, 2025
@Jeremy-Walton Jeremy-Walton force-pushed the sidebar-and-dialog-improvements branch from db3fcbf to fdc8e18 Compare January 7, 2026 00:30
@Jeremy-Walton Jeremy-Walton merged commit ad61a76 into main Jan 7, 2026
5 checks passed
@Jeremy-Walton Jeremy-Walton deleted the sidebar-and-dialog-improvements branch January 7, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Base Tokens Changes to the base tokens Components Changes to a component enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

Sidebar and <dialog> modal improvements

3 participants