Repository navigation
test: tolerate wrapped cargo failure diagnostics - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Make the developer-check fixture accept Windows PowerShell line wrapping in the
expected Cargo failure, including wrapping inside an argument. Require the full
diagnostic with exit code 7 and exactly one
fmt --all -- --checktrace entry.The process-level failure check remains unchanged.
Why
On a long checkout path, Windows PowerShell 5.1 splits
--allacross outputlines. The original contiguous-string assertion fails even though the fake
Cargo correctly failed at the first command. Whitespace tolerance is limited to
this diagnostic; the trace check also rejects repeated or additional commands.
Base:
mainat8c459778b4fc726ef6b62d03e150adfcbbac3eda, matching the acceptedone-file correction. This is a separate draft for review. The v0.2.1 candidate
and its tag target remain at that base; this PR does not change the release.
How it was tested
Reproduced the original failure on Windows PowerShell 5.1.26100.9444.
20 synthetic cases exercise the actual assertion ASTs: accepted formatting,
wrong/missing failure diagnostics, extra/repeated commands, and the unchanged
process-level success/failure guard.
Developer suite: exit 0 on script paths of 80, 109 and 192 characters, including
spaces. Copied scripts were byte-identical; temporary fixtures were removed.
Docs: exit 0, 27 Markdown files; local anchors are outside checker coverage.
Smoke-safety: exit 0, seven preflight cases and the safety suite with fake
process/task/build callbacks. All five native suite stderr logs are empty.
Whitespace, local content/metadata privacy and secret checks passed.
No general local build, real protection runtime or hardware acceptance was
run for this test-only change. Hosted PR CI is tracked separately.
scripts/check.ps1 -Mode Fulllocally (not run: no Rust changes)tests/developer_checks.ps1passes for the developer-tooling changetests/smoke_safety.ps1passesRelevant local checks run with synthetic fixtures; runtime/manual limits stated
Product documentation needs no change: only test assertions change
Checklist