Add behavioral sync test suite and fix ETag-fallback conflict bug#149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a behavioral test suite for the sync pipeline and fixes a conflict-detection bug surfaced while writing it.
Tests
FakeSession/FakeResponse) with route registration, call counting, and a guard that fails on unexpected requests.download_filebehavior tests: chunked-to-disk download, in-run path dedup, and everyupdate_files_conflictmode (keep/none/overwrite/rename + unknown->rename).assert_snapshothelper withSMM_UPDATE_SNAPSHOTS=1to regenerate snapshots.test_course_prefix_handlingfromunittestto pytest style for consistency.Fix
download_file: a failed local-vs-cache ETag comparison no longer silently overwrites the local file. A faulty/unreadable ETag cache is now treated as if no cached ETag existed, falling back to the timestamp/HEAD heuristic to decide whether the local copy was modified.Closes #73