fix: validate deserialized API messages at boundary to prevent crashes

[roomote]

Fixes the "Cannot read properties of undefined (reading 'filter')" error reported in Reddit.

Root Cause Analysis

The error occurred in filterNonAnthropicBlocks() when it tried to call .filter() on message.content that was undefined, null, or not an array.

However, the type system guarantees content is string | ContentBlock[], so receiving undefined means we have a type safety violation at the deserialization boundary.

The Real Problem

In readApiMessages(), we deserialize JSON with zero validation:

const parsedData = JSON.parse(fileContent)
return parsedData  // No validation - assumes data is valid

This allows corrupted or legacy data from disk to bypass TypeScript's type safety, creating messages with undefined content that violate the Anthropic.MessageParam contract.

Evidence this is a known issue:

• ClineProvider.ts:3315-3317 already has defensive checks for non-array deserialized data
• openai-format.ts:194 uses as any casts that could create malformed messages

Solution

Add validation at the deserialization boundary in readApiMessages() to sanitize data before it enters the type system:

Changes Made

1. Added validateApiMessage() function that:

   • Validates message structure (must be object with valid role)
   • Fixes undefined/null/non-array content by converting to empty array
   • Filters out invalid content blocks (missing type field)
   • Logs warnings about corrupted data for debugging

2. Updated readApiMessages() to validate each deserialized message

3. Added 12 comprehensive tests covering:

   • Undefined/null content
   • Non-array, non-string content
   • Invalid roles
   • Malformed messages (non-objects)
   • Invalid content blocks
   • Legacy format compatibility

Testing

All 12 new tests pass, ensuring the validation properly handles:

• ✅ Valid messages (pass through unchanged)
• ✅ Undefined content (fixed to empty array)
• ✅ Null content (fixed to empty array)
• ✅ Invalid content types (fixed to empty array)
• ✅ Invalid roles (filtered out)
• ✅ Malformed messages (filtered out)
• ✅ Invalid content blocks (filtered out)
• ✅ Metadata preservation (ts, isSummary, etc.)

Impact

This fix prevents crashes when loading historical tasks with corrupted data, while maintaining backward compatibility with valid historical data. Users will no longer encounter the "Cannot read properties of undefined" error when using Anthropic models.

Related

• Closed PR fix: prevent crash when message.content is undefined in Anthropic API calls #10954 which treated the symptom (added defensive checks in filterNonAnthropicBlocks) rather than the root cause

---

View task on Roo Code Cloud

---

Important

Adds validation to deserialized API messages in readApiMessages() to prevent crashes from malformed data.

• Behavior:
  • Adds validateApiMessage() in apiMessages.ts to validate deserialized messages, fixing undefined/null/non-array content and filtering invalid messages.
  • Updates readApiMessages() to use validateApiMessage() for each message, ensuring only valid messages are processed.
• Testing:
  • Adds 12 tests in apiMessages.spec.ts to cover various cases including undefined/null content, invalid roles, malformed messages, and metadata preservation.
• Misc:
  • Logs warnings and errors for invalid messages and parsing issues in apiMessages.ts.

^{This description was created by for bbdcab3. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Rooviewer   See task on Roo Cloud

Review completed. No issues found.

This PR correctly fixes the root cause of the "Cannot read properties of undefined (reading 'filter')" crash by adding validation at the deserialization boundary in readApiMessages(). The implementation:

• Validates message structure and role
• Fixes undefined/null/invalid content by converting to empty array
• Filters invalid content blocks missing the required type field
• Has comprehensive test coverage (12 tests covering all edge cases)

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}