Skip to content

[Improve] Offer bounded monitoring for ongoing processes - #2291

Merged
daniel-lxs merged 2 commits into
developfrom
feature/ongoing-process-follow-up-2ss2irs229l3v
Sep 6, 2026
Merged

[Improve] Offer bounded monitoring for ongoing processes#2291
daniel-lxs merged 2 commits into
developfrom
feature/ongoing-process-follow-up-2ss2irs229l3v

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

Related issue

Requested in the linked task discussion; no linked issue. Inspected #2268, which remains open and proposes specialized required-check notifications; this change neither imports nor depends on that policy.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

Useful verification can happen after the current turn. Fast should offer that follow-up when it can resolve a concrete outstanding outcome, without turning every closeout into a monitoring pitch.

What changed

  • Add three generic Fast prompt rules for bounded ongoing-process follow-up, rather than modifying individual workflows.
  • Gate offers on a concrete unresolved outcome and actual verification capability. Ask one specific consent question with timing and a stop bound; never imply deployment or completion without evidence.
  • Require acceptance before scheduling an offer while preserving direct scheduling for explicit monitoring requests. Revalidate capability, reuse equivalent wakeups, keep monitoring quiet and finite, and avoid duplicate notifications or repeated offers.
  • Align the shared wakeup tool description and schedule-field guidance with finite ongoing-process monitoring, including bounded interval/cron examples and stopping without renewal. Preserve unbounded explicitly requested recurring reminders and reports.
  • Add four focused prompt/tool-contract tests. No scheduling infrastructure or notification handlers changed.

How it was tested

  • 99 tests passed: Fast prompt and wakeup args, parser, schedule and shared tool-contract suites via package-scoped Vitest.
  • pnpm --filter @roomote/cloud-agents check-types, pnpm --filter @roomote/types check-types and git diff --check passed.
  • Normal pre-commit formatting and pre-push oxlint, residual lint, fast typechecks and Knip passed. Knip emitted one non-failing existing configuration hint.
  • Browser proof is not applicable to this prompt-generation change. No live-model behavioral evaluation or real monitoring schedules were run; contract tests verify prompt content, not model compliance. Full root test suite and root pnpm lint/pnpm check-types were not run.

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

@roomote-community

roomote-community Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

  • packages/cloud-agents/src/server/fast-agent/fast-agent-prompt.ts:342 The bounded-monitoring rule conflicts with the wakeup tool guidance that permits unbounded monitors.

Reviewed 32266f5

Comment thread packages/cloud-agents/src/server/fast-agent/fast-agent-prompt.ts
@roomote-roomote

roomote-roomote Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

Fixed the conflicting wakeup guidance in 32266f56 and resolved the review thread. Ongoing-process monitors now require finite schedules in both the shared tool description and schedule-field guidance; explicitly requested recurring reminders/reports remain supported. Added regression coverage: 99 targeted tests, both affected package typechecks and normal pre-push gates passed. PR metadata refreshed. The updated Roomote review summary for this commit reports No code issues found. Browser proof is not applicable; live-model behavior was not tested.

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review September 6, 2026 16:35
@daniel-lxs
daniel-lxs merged commit 979f178 into develop Sep 6, 2026
17 checks passed
@daniel-lxs
daniel-lxs deleted the feature/ongoing-process-follow-up-2ss2irs229l3v branch September 6, 2026 16:39
@roomote-roomote roomote-roomote Bot mentioned this pull request Sep 6, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant