[Fix] Saved Slack destinations lose their selection checkmark - #2301
Merged
roomote-roomote[bot] merged 1 commit intoSep 7, 2026
Merged
Conversation
Contributor
daniel-lxs
marked this pull request as ready for review
September 7, 2026 03:17
daniel-lxs
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 7, 2026 03:17
daniel-lxs
approved these changes
Sep 7, 2026
roomote-roomote
Bot
deleted the
fix/slack-channel-selection-3qgx8ji79ww0j
branch
September 7, 2026 03:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Saved Slack automation destinations retain their checkmark when the settings form reloads a channel name rather than its ID. The marker now uses the same resolved option as the picker label. Selecting another channel still emits its canonical ID.
Added focused coverage for canonical IDs, hydrated names and labels, unmatched values, and changing a saved selection.
Why this change was made
In Weekly Manager Stats, selecting a channel and saving persisted its canonical ID correctly, but reopening the settings picker showed no checkmark. The form hydrates the display name, while the old marker compared it directly with the ID. This was a display inconsistency, not a lost destination or failed Slack delivery.
Impact
No persistence, routing, or provider behavior changes. The fix reuses the existing channel matching result.
On baseline
d95a5fd045ff82f81d458256a6a871ec9cda611a, the real application save/reload path returnedC123ABC456and#product-debug, but both menu markers had opacity 0. With this change, only the saved channel is marked. Changing to#engineering, resetting, saving the new channel, and reloading preserved the expected marker and canonical database target. Slack was the repository's local mock provider; this does not establish real Slack authorization or message delivery.The six focused cases and adjacent automation tests passed (62 tests across five files), as did web typechecking, formatting, focused lint, and the full pre-push lint/typecheck/knip gates.
Final-head visual proof was recovered in one separately authorized bounded attempt on
0ef6f963a43184c6acf08983bee679f1e9642d9b. The actual save/reload/change/reset path and desktop/mobile marker states passed; the proof package was uploaded and handed off within five minutes, then independently inspected. CI, CodeQL, and CLA passed. The PR remains draft pending the in-progress Roomote review; no review approval is claimed.Screenshots
These captures use the repository's local mock Slack provider and a synthetic installation. Application form submission, persistence, and reload are real. Images show rendered states, not real Slack authorization, delivery, or a recording of the temporal sequence.
Saved destination after page reload:
Changed selection:
Reset restores the saved destination at mobile width: