[Fix] Pull request delivery selector has no accessible name

[roomote-roomote]

​Opened on behalf of @daniel-lxs. View the task or mention @roomote-roomote for follow-up asks.

Related issue

No linked issue; maintainer-authorized accessibility investigation.

Why this PR exists

• A maintainer explicitly invited this PR in the linked issue or discussion
• I am a maintainer / this is internal Roomote work

The Pull request delivery selector had no accessible name. The real browser accessibility tree exposed an unnamed combobox, and scoped axe reported a critical button-name violation.

What changed

Give the selector the accessible name Pull request delivery, matching its visible setting label. Update the test double to preserve button attributes and assert the named combobox. Selection, saving, deployment defaults and visible layout are unchanged.

How it was tested

Base d95a5fd045ff82f81d458256a6a871ec9cda611a; exact head 93772a4157daaec85712e3142f18f11e8d0f044f.

• Real authenticated /settings/source-control path: scoped axe changed from one critical button-name violation to zero violations, zero incomplete and 13 passes on desktop and 390x844 mobile. The accessibility tree now names the combobox.
• Keyboard Enter opens all three delivery options. Arrow navigation followed by Escape returns focus to the named selector without changing Draft selection. No deployment setting was changed during this check.
• The named-role assertion failed before the fix. All 21 SourceControl tests pass afterward, including existing delivery mutation behavior: pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/web exec vitest run src/components/settings/SourceControl.test.tsx.
• Web fast typecheck, targeted oxlint and diff checks passed. Actual commit/pre-push gates passed formatting, full oxlint, residual ESLint, fast typechecks and knip (existing non-failing mint hint).
• Both final-diff screenshots were inspected; no source drift or simulation. Screenshots establish layout and the keyboard-opened menu; accessibility-tree and axe results establish the accessible-name claim. External provider delivery, screen-reader speech output and full repository tests were not exercised.

Screenshots

Desktop, actual local product, keyboard-opened menu:

Mobile 390x844, actual local product, keyboard-opened menu:

Related PRs

• [Fix] Doctor reports blank auth credentials as configured #2300 and [Fix] Unsupported prompt attachments disappear without feedback #2302: independent earlier changes from the same bounded work. This branch starts directly from develop and depends on neither.

Checklist

• The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
• This PR is small and scoped to one change
• pnpm lint and pnpm check-types pass locally
• I added tests or included a clear manual validation note above
• I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
• If this change should appear in the changelog, I ran pnpm changeset

The full pre-push static suite passed; exact formatting-inclusive full lint and full tsc commands were not both run. No changeset added for this small accessibility correction.

[roomote-community]

Reviewing the PR now. Follow

_{Reviewing 93772a4}