[Fix] Suggested tasks start in a new Slack thread when launched from Fast reports - #2307
Open
roomote-roomote[bot] wants to merge 4 commits into
Open
[Fix] Suggested tasks start in a new Slack thread when launched from Fast reports#2307roomote-roomote[bot] wants to merge 4 commits into
roomote-roomote[bot] wants to merge 4 commits into
Conversation
Contributor
Contributor
Author
|
Resolved the outstanding router-backed Fast launch finding in 21469cc0.
The review thread is resolved and PR metadata refreshed. Live provider replay was not performed. |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 7, 2026 04:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
requireFastSuggestionOriginSessionId(fastConversationId)from the SDK server and suggestion module so other publishers can use the same canonical lookup. Taskless Slack message metadata now carriessourceTaskId: null, not an automation event ID.Why this change was made
Fast automation reports can publish suggestions without a source task. Their work items correctly have
sourceTaskId: null, but the publisher also omitted the originating Session. Slack reactions only resolved origins through the source task, so they posted a new channel-root announcement even though the report's Session already had the correct Slack thread binding. This is a separate path from the task-backed publication fixed in #2277.Impact
New Fast report cards retain Session ownership from publication through launch. No Session is created lazily to recover the origin, and card timestamps do not become the routing authority. No schema migration or historical backfill is included: existing taskless cards without origin metadata need a newly generated report. Live Slack delivery and the deployed version associated with the original report have not been verified.
How it was tested
thread_ts. They pass with the fix restored.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetValidation used the scoped TypeScript checks and repository pre-push gates described above rather than the two full commands in the checklist. No changeset was added.