configurator: colocate Synology backup default under /volume1/docker#21
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Synology platform defaults in the configurator so the backup volume path is colocated with the Roon app data under /volume1/docker, aligning the layout with other supported NAS platforms.
Changes:
- Change Synology default
backuppath to/volume1/docker/roon-backups. - Update unit test fixture expectations for Synology defaults.
- Update Playwright E2E assertion for Synology platform switching.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| configurator/public/platforms/synology.json | Updates the Synology platform’s default backup path. |
| configurator/src/urlState.test.ts | Updates unit test fixtures/expectations to match the new Synology backup default. |
| configurator/e2e/configurator.spec.ts | Updates E2E assertion when switching to the Synology platform. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Match the QNAP convention of keeping roon and roon-backups together under the container app-data root. Previously backup defaulted to /volume1/roon-backups while roon lived at /volume1/docker/roon.
decriptor
force-pushed
the
shaw/fix-synology-generator
branch
from
2adf2a2 to
cf8cfb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backupwas/volume1/roon-backups, butroonlived at/volume1/docker/roon— inconsistent within the platform and out of step with QNAP, which keeps both under/share/Container/./volume1/docker/roon-backupsso generated compose output groups Roon's app data and backups together.urlState.test.tsand the Playwright assertion inconfigurator.spec.tsthat snapshot the default.Test plan
npx vitest run(119/119 passing)npx playwright testto confirm the e2e platform-switching assertionvol-backuppopulates/volume1/docker/roon-backupsand the rendered compose output reflects it