Potential fix for code scanning alert no. 2: Uncontrolled command line#10
Merged
Rootless-Ghost merged 1 commit intomasterfrom Apr 13, 2026
Merged
Potential fix for code scanning alert no. 2: Uncontrolled command line#10Rootless-Ghost merged 1 commit intomasterfrom
Rootless-Ghost merged 1 commit intomasterfrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Rootless-Ghost/AtomicLoop/security/code-scanning/2
Best fix: enforce an execution allowlist in
core/executor.pysoexecute()only runs command strings that exactly match the known atomic commands/cleanup commands for the selected executor type. This preserves existing behavior (running embedded tests) while blocking any command that is not part of the predefined catalog.Implementation details:
core/executor.py_is_allowed_atomic_command(command, executor_type)that importsATOMICSlocally and checks exact match againstcommandandcleanup_commandfrom catalog tests for that executor.execute(), after normalizingexecutor_typeand beforedry_run/execution, reject commands that are not allowlisted by returningExecutionResult(..., error=...).No new third-party dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.