Potential fix for code scanning alert no. 13: Uncontrolled command line#14
Merged
Rootless-Ghost merged 1 commit intomasterfrom Apr 25, 2026
Merged
Potential fix for code scanning alert no. 13: Uncontrolled command line#14Rootless-Ghost merged 1 commit intomasterfrom
Rootless-Ghost merged 1 commit intomasterfrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Rootless-Ghost/AtomicLoop/security/code-scanning/13
General fix: never pass user-controlled command text directly into
-Commandscript content. Instead, resolve user input to a predefined allowlisted command and only embed that resolved value.Best fix here (without changing intended functionality): in
core/remote_executor.py, after_is_allowed_atomic_command(command)succeeds, normalize and resolve the command through a local hardcoded allowlist mapping (allowed_commands) and use the resolved command inps_script. This makes execution deterministic and removes direct use of tainted input in the command construction path. Keep existing behavior for disallowed commands by returning the same policy error.Changes needed:
core/remote_executor.pyallowed_commandsmap and resolvecommandtoresolved_command.resolved_commandinInvoke-Command ... -ScriptBlock.Suggested fixes powered by Copilot Autofix. Review carefully before merging.