Skip to content

Fix NV modem discovery on shared MAVLink links - #58

Merged
Rouniy merged 1 commit into
mainfrom
hotfix/nv-modem-discovery
Aug 23, 2026
Merged

Fix NV modem discovery on shared MAVLink links#58
Rouniy merged 1 commit into
mainfrom
hotfix/nv-modem-discovery

Conversation

@Rouniy

@Rouniy Rouniy commented Aug 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • register the private SkyComm MAVLink dialect before any shared connection begins reading
  • discover NV5 from its private status/configuration messages and NV4 from UAVCAN_NODE_INFO names NV_TX/NV_RX
  • remove system/component ID range assumptions and probe every endpoint already observed by each shared link
  • replay cached discovery packets when the setup page opens after a modem was already seen
  • clarify that NV Modem uses Mission Planner's existing connection and never opens a second port

Verification

  • 1132/1132 Release tests passed
  • focused NV modem tests: 21/21 passed
  • Debug app build: 0 warnings, 0 errors
  • changed-file dotnet format verification passed

@Rouniy
Rouniy merged commit 1e16a30 into main Aug 23, 2026
6 checks passed
@Rouniy
Rouniy deleted the hotfix/nv-modem-discovery branch August 23, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant