fix(dialogs): keep choice actions inside the window - #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reported regression
The four-action update prompt used the generic fixed 380px frame, causing the Later button to paint past the client edge and be clipped.
CI follow-up
The first PR run exposed an existing hosted-macOS DiskImages flake after the app had already published, signed, and verified. An earlier run had failed at the same boundary on the opposite architecture with
Resource temporarily unavailable. DMG creation and immediate verification now get three attempts with 2s/4s backoff; partial output is removed before recreation, and persistent failures still fail the job.Verification
DialogLayoutTests: 1/1 passed using the exact updater labels/dev/video0normalization case failed229e587c5Manual acceptance
Open a four-action choice such as the prompt for a genuinely newer signed release and confirm every action, including Later, is fully visible and clickable.