fix(flight-data): scale bearing vectors with map - #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Live validation showed that upstream-style constant screen-pixel vectors are unsuitable in the Avalonia map: the default 500-pixel lines span countries at regional and world zoom. This change deliberately uses stable map-distance vectors instead.
With a configured 500m vector, the regression verifies 250px at resolution 2, 62.5px after zooming to resolution 8, and 62.5px after the next vehicle redraw.
Verification
Manual acceptance
Rebuild and relaunch this branch, connect a live vehicle, then zoom Flight Data to a regional or world view. Bearing vectors should stay local to the aircraft and shrink with the map, with no duplicated aircraft symbols.