Fix Nubmage gossip routing and Daish formation#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across database formation logic, NPC gossip handling, and repository ownership assignment. The most significant changes involve correcting formation member registration and angle conventions, improving robustness in NPC gossip option resolution, and updating code ownership.
Formation and database logic improvements:
creature_formationsentry for Daish: Only the escorts are now registered as members of the leader's formation, and follow angles are stored in degrees (90.0 for left flank, 270.0 for right flank), aligning with AzerothCore conventions. Also, removed the leader's entry as a member and changedgroupAIto 0 for the escorts.NPC gossip handling robustness:
npc_nubmagegossip handler to resolve the selected action viaPlayerTalkClassbefore processing. This prevents misrouting when menu rows shift or become stale, ensuring the correct portal destination is selected regardless of how the gossip option arrives.Repository ownership:
@rovxbot) for all files in.github/CODEOWNERS, improving repository maintenance and accountability.