Fix/kappa update and nubmage spells#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds incremental SQL update scripts for the Nubmage, Daish, and Kappa custom NPCs, enabling seamless updates for existing AzerothCore world databases. The documentation (
README.md) is updated to clarify installation and update procedures, and the Nubmage portal logic is refactored to use spell IDs instead of coordinates for teleportation.Database update scripts for existing installs:
data/sql/db-world/updates/2026_03_11_00_kappa.sql, an auto-applied SQL update for the new Kappa NPC, supporting incremental updates for existing databases.data/sql/db-world/updates/2026_03_11_01_nubmage_reapply.sqlanddata/sql/db-world/updates/2026_03_11_02_daish_reapply.sql, providing full cleanup and reapplication of Nubmage and Daish NPCs for existing databases. These scripts ensure safe re-runs and proper handling of child/parent relationships. [1] [2]Documentation improvements:
README.mdto distinguish between fresh installs (usingbase/SQL files) and incremental updates (usingupdates/), and clarified rebuild/restart requirements. Also added descriptions for new SQL files and update scripts. [1] [2] [3]Code refactoring:
src/npc_nubmage.cppto use spell IDs for teleportation instead of hardcoded coordinates, simplifying maintenance and improving reliability.