Repository navigation
Conversation
Migrate both windivert-sys and windivert to windows 0.62 and thiserror 2, adapting to breaking API changes: - BOOL moved from Win32::Foundation to windows::core - HANDLE.0 changed from isize to *mut c_void - TlsSetValue, ControlService, CloseServiceHandle now return Result<()> - Error::from_win32() replaced by Error::from_thread() - Fix dangling pointer in uninstall() MaybeUninit usage - Bump MSRV to 1.81 (required by thiserror 2) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
HANDLE changed from isize to *mut c_void in windows 0.58+, which removes auto Send/Sync. Restore them with explicit unsafe impls since Win32 kernel handles are safe to send/share across threads. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
Hi At the moment I would prefer not bumping the msrv on master, I'd like to keep it as a reference for the latest stable public version. Also the changes have already been implemented in the dev branch and published in the 0.7 pre-relase versions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windowscrate from 0.48 to 0.62 in bothwindivert-sysandwindivertthiserrorfrom 1 to 2 in both cratesBOOLmoved towindows::core,HANDLE.0is now*mut c_void, several Win32 functions now returnResult<()>,Error::from_win32()replaced byError::from_thread())uninstall()MaybeUninitusagethiserror2)Test plan
cargo check --features vendoredcompiles cleanly with no warningscargo check --features staticcompiles cleanlycargo test --features vendoredpasses🤖 Generated with Claude Code