Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements the egg hatching feature by introducing new commands, views, and processors to register eggs, inject love points, and transition egg states. It also adds corresponding endpoints and repository queries along with test code updates.
- Added DTOs and commands for egg registration and love point usage.
- Implemented processors and repository methods for incubating egg creation, love point updates, and egg state transitions.
- Updated controllers to expose new endpoints for egg hatching flows.
Reviewed Changes
Copilot reviewed 50 out of 50 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/org/runimo/runimo/user/service/dtos/RegisterEggCommand.java | New DTO for egg registration |
| src/main/java/org/runimo/runimo/user/service/dtos/IncubatingEggView.java | New view for displaying incubating egg details |
| src/main/java/org/runimo/runimo/user/service/UserItemProcessor.java | Updated to log item activity during item quantity updates and usage |
| src/main/java/org/runimo/runimo/user/service/LovePointProcessor.java | Added Transactional annotation and updated comment for love point processing |
| src/main/java/org/runimo/runimo/user/service/IncubatingEggProcessor.java | Introduced creation and love point update logic for incubating eggs |
| src/main/java/org/runimo/runimo/user/service/IncubatingEggFinder.java | Finder for incubating egg list and view retrieval |
| src/main/java/org/runimo/runimo/user/repository/IncubatingEggRepository.java | Repository queries for incubating eggs with XLock support |
| src/main/java/org/runimo/runimo/user/enums/UserHttpResponseCode.java | New response codes for egg registration and love point usage |
| src/main/java/org/runimo/runimo/user/domain/IncubatingEgg.java | Domain model for incubating eggs with state transition logic |
| src/main/java/org/runimo/runimo/user/domain/EggStatus.java | Egg status enum updated for incubation flow |
| src/main/java/org/runimo/runimo/user/controller/** | Controllers and requests adapted for new egg endpoints |
Comments suppressed due to low confidence (1)
src/main/java/org/runimo/runimo/user/service/dtos/IncubatingEggView.java:20
- [nitpick] The parameter name 'hatchable' (of type EggStatus) is potentially misleading since it represents a status rather than a boolean. Consider renaming it to 'eggStatus' for clarity.
public IncubatingEggView(Long id, String name, String imgUrl, Long hatchRequiredPointAmount, Long currentLovePointAmount, EggStatus hatchable) {
src/main/java/org/runimo/runimo/user/repository/IncubatingEggRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/org/runimo/runimo/user/service/IncubatingEggProcessor.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내역
부화기능 구현
테스트 코드 작성
Notice
aaaWithXLock이라고 표시하고 있습니다.