Skip to content

[FIX/add-not-null-constraint] : 쿼리에 Null조건 추가#100

Merged
ekgns33 merged 1 commit intomainfrom
fix/add-not-null-constraint
Jun 15, 2025
Merged

[FIX/add-not-null-constraint] : 쿼리에 Null조건 추가#100
ekgns33 merged 1 commit intomainfrom
fix/add-not-null-constraint

Conversation

@ekgns33
Copy link
Contributor

@ekgns33 ekgns33 commented Jun 13, 2025

작업내역

  • oauth 유저 조회 시 not null 조건이 누락되어 추가했습니다.

5fb70779b118e9a78e00bace9c705efc009e3320

Screenshot 2025-06-14 at 12 41 04 AM

Summary by CodeRabbit

  • Refactor

    • Improved method naming for clarity regarding deleted records in user authentication checks.
    • Enhanced consistency in formatting and code annotations.
  • Bug Fixes

    • Ensured that deleted OAuth records are not considered when checking for existing users during registration.

@ekgns33 ekgns33 requested a review from jeeheaG June 13, 2025 15:41
@ekgns33 ekgns33 self-assigned this Jun 13, 2025
@ekgns33 ekgns33 added the bug Something isn't working label Jun 13, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jun 13, 2025

Walkthrough

The changes update the OAuthInfoRepository interface by renaming a method to explicitly include a deleted-at-null check in its name and remove parameter validation annotations. Correspondingly, the UserRegisterService now uses this renamed method to ensure only non-deleted OAuth info records are considered when validating existing users. No functional logic is otherwise altered.

Changes

File(s) Change Summary
src/main/java/org/runimo/runimo/user/repository/OAuthInfoRepository.java Reformatted queries, removed @NotNull annotations, renamed method to include deleted-at-null check.
src/main/java/org/runimo/runimo/user/service/UserRegisterService.java Updated to use the renamed repository method for non-deleted OAuth info existence checks.

Poem

In the warren of code where the rabbits play,
A method was renamed in a thoughtful way.
Deleted-at checks now clear and bright,
User checks hopping along just right.
With tidy code and queries anew,
The burrow’s logic shines right through! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 38f9d37 and 5fb7077.

📒 Files selected for processing (2)
  • src/main/java/org/runimo/runimo/user/repository/OAuthInfoRepository.java (1 hunks)
  • src/main/java/org/runimo/runimo/user/service/UserRegisterService.java (1 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@jeeheaG jeeheaG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 몇가지 질문드립니다!

@ekgns33 ekgns33 merged commit 444c74c into main Jun 15, 2025
3 checks passed
@ekgns33 ekgns33 deleted the fix/add-not-null-constraint branch June 15, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants