Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for detailed pace information to running record data by introducing segment pace handling throughout the codebase. Key changes include:
- Integrating segment pace data into RecordSaveRequest, RecordCreateCommand, and related DTOs.
- Updating tests to use RecordFixtures and verify the new pace information.
- Modifying domain models and converters to persist and retrieve segment pace lists.
Reviewed Changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| RewardAcceptanceTest.java | Updated to use fixture for RecordSaveRequest and added a new parameter for segment pace data (currently passed as null in some tests) |
| RewardTest.java | Updated to include an empty list for segment pace data in test cases |
| RecordAcceptanceTest.java | New test file verifying record creation and fetching with segment pace data |
| RecordFixtures.java | New fixture method for creating a RecordSaveRequest with segment pace data |
| SegmentPace.java | Introduced a new record for segment pace data |
| RecordDetailViewResponse.java | Updated to return primitive values and include segment pace list |
| RecordCreateCommand.java | Modified command to accept a list of segment paces |
| RecordQueryUsecaseImpl.java, RecordQueryUsecase.java | Changed method signature to use Long record identifiers |
| RecordCommandService.java | Mapped new segment pace list from the command to the entity |
| RecordHttpResponse.java | Adjusted response codes and messages for record fetching |
| SegmentPaceConverter.java | Added converter to serialize/deserialize segment pace lists |
| RunningRecord.java | Modified to persist the segment pace list and updated accessor methods |
| RecordSaveRequest.java | Updated to include a field for segment pace data |
| RecordController.java | Modified endpoint signature and response wrapper for record viewing |
| Pace.java | Added a getter for paceInMilliSeconds |
Files not reviewed (2)
- src/main/resources/sql/schema.sql: Language not supported
- src/test/resources/sql/schema.sql: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업내역
세부페이스 정보 추가
테스트 코드작성