Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances authentication by including additional user information in the auth responses and updating the response DTOs for login and signup operations. Key changes include:
- Updating login and signup methods to return richer responses with user nickname and image URL.
- Removing the old SignupUserInfo DTO and introducing SignupUserResponse.
- Adjusting tests to extract the access token from a nested token_pair field.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/org/runimo/runimo/user/api/UserItemAcceptanceTest.java | Updates the test to extract the access token from payload.token_pair |
| src/main/java/org/runimo/runimo/user/service/usecases/UserOAuthUsecaseImpl.java | Modifies login and signup methods to wrap responses in new DTOs |
| src/main/java/org/runimo/runimo/user/service/usecases/UserOAuthUsecase.java | Updates interface return types to reflect new DTOs |
| src/main/java/org/runimo/runimo/user/service/dtos/AuthResponse.java | Changes AuthResponse to include nickname and imgUrl |
| src/main/java/org/runimo/runimo/user/service/dtos/SignupUserResponse.java | Introduces a new DTO carrying additional user information |
| src/main/java/org/runimo/runimo/user/controller/UserItemController.java | Adds a new endpoint for using items |
| src/main/java/org/runimo/runimo/user/controller/UserController.java | Updates endpoints to use new auth response DTOs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업내역