Skip to content

[Feat/main page view]#9

Merged
ekgns33 merged 2 commits intomainfrom
feat/main-page-view
Mar 28, 2025
Merged

[Feat/main page view]#9
ekgns33 merged 2 commits intomainfrom
feat/main-page-view

Conversation

@ekgns33
Copy link
Contributor

@ekgns33 ekgns33 commented Mar 28, 2025

작업 내용

  • 메인 화면 뷰 제공 API 구현
  • 테스트코드 작성

@ekgns33 ekgns33 requested a review from Copilot March 28, 2025 15:19
@ekgns33 ekgns33 self-assigned this Mar 28, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the main page view API and adds corresponding unit and acceptance tests. Key changes include:

  • Implementation of the MainViewQueryUsecase and its DTO, MainViewResponse.
  • Addition of unit tests (MainViewControllerTest) and acceptance tests (MainViewAcceptanceTest) for the API.
  • Updates to repository and processor methods to support egg retrieval and record counting.

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/test/java/org/runimo/runimo/user/api/MainViewControllerTest.java Adds unit tests for the main view API endpoint.
src/test/java/org/runimo/runimo/user/api/MainViewAcceptanceTest.java Adds end-to-end API tests using RestAssured.
src/main/java/org/runimo/runimo/user/service/usecases/MainViewQueryUsecaseImpl.java Implements the main view query usecase with proper aggregation.
src/main/java/org/runimo/runimo/user/service/dtos/MainViewResponse.java Defines the DTO for main view response.
src/main/java/org/runimo/runimo/user/service/UserItemProcessor.java Updates the method to acquire a lock when fetching user items.
src/main/java/org/runimo/runimo/user/service/UserItemFinder.java and repository Introduces egg retrieval methods.
src/main/java/org/runimo/runimo/records/service/RecordFinder.java and repository Adds record counting functionality.
src/main/java/org/runimo/runimo/user/controller/MainViewController.java Exposes the main view endpoint with proper Swagger annotations.
Files not reviewed (1)
  • src/test/resources/sql/main_view_data.sql: Language not supported

@ekgns33 ekgns33 merged commit 8970df3 into main Mar 28, 2025
1 check passed
@ekgns33 ekgns33 deleted the feat/main-page-view branch April 16, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants