Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements the main page view API and adds corresponding unit and acceptance tests. Key changes include:
- Implementation of the MainViewQueryUsecase and its DTO, MainViewResponse.
- Addition of unit tests (MainViewControllerTest) and acceptance tests (MainViewAcceptanceTest) for the API.
- Updates to repository and processor methods to support egg retrieval and record counting.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/org/runimo/runimo/user/api/MainViewControllerTest.java | Adds unit tests for the main view API endpoint. |
| src/test/java/org/runimo/runimo/user/api/MainViewAcceptanceTest.java | Adds end-to-end API tests using RestAssured. |
| src/main/java/org/runimo/runimo/user/service/usecases/MainViewQueryUsecaseImpl.java | Implements the main view query usecase with proper aggregation. |
| src/main/java/org/runimo/runimo/user/service/dtos/MainViewResponse.java | Defines the DTO for main view response. |
| src/main/java/org/runimo/runimo/user/service/UserItemProcessor.java | Updates the method to acquire a lock when fetching user items. |
| src/main/java/org/runimo/runimo/user/service/UserItemFinder.java and repository | Introduces egg retrieval methods. |
| src/main/java/org/runimo/runimo/records/service/RecordFinder.java and repository | Adds record counting functionality. |
| src/main/java/org/runimo/runimo/user/controller/MainViewController.java | Exposes the main view endpoint with proper Swagger annotations. |
Files not reviewed (1)
- src/test/resources/sql/main_view_data.sql: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용