Conversation
tarcieri
force-pushed
the
keccak/make-asm-and-simd-into-cfg-keccak-backend
branch
from
60dd4b2 to
f4ed03f
Compare
newpavlov
reviewed
Feb 13, 2026
Member
|
The ASM backend could use a callback API, otherwise we branch on the target feature availability on each processed block. But I guess we could do it in future versions. |
newpavlov
approved these changes
Feb 13, 2026
tarcieri
force-pushed
the
keccak/make-asm-and-simd-into-cfg-keccak-backend
branch
from
f4ed03f to
b3e0bc9
Compare
Member
Author
|
@newpavlov I had a separate idea for how to address CPU feature detection, but I'll do that in a followup |
Replaces these non-additive "features" with a 1-of-n backend selection enabled by using `cfg` instead. - `asm` => `--cfg keccak_backend="asm"` - `simd` => `--cfg keccak_backend="simd"`
tarcieri
force-pushed
the
keccak/make-asm-and-simd-into-cfg-keccak-backend
branch
from
b3e0bc9 to
c77424b
Compare
tarcieri
deleted the
keccak/make-asm-and-simd-into-cfg-keccak-backend
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces these non-additive "features" with a 1-of-n backend selection enabled by using
cfginstead.asm=>--cfg keccak_backend="armv8_asm"simd=>--cfg keccak_backend="simd"Closes #85