Skip to content

Improve title resolution #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ryder-C merged 2 commits into from
Jul 24, 2026
Merged

Improve title resolution #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54919db
fix: stop evicting title caches per generic-search page
Ryder-C Jul 21, 2026
10de638
perf: resolve generic-search titles concurrently
Ryder-C Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 1 addition & 81 deletions src/radarr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use std::{
collections::{HashMap, HashSet},
collections::HashMap,
io::ErrorKind,
path::{Path, PathBuf},
sync::Arc,
Expand Down Expand Up @@ -114,29 +114,6 @@ impl RadarrClient {
Ok(movie)
}

pub async fn retain_titles(&self, keep: &HashSet<i64>) -> Result<(), RadarrError> {
if keep.is_empty() {
let mut guard = self.cache.write().await;
if guard.is_empty() {
return Ok(());
}
guard.clear();
drop(guard);
return self.persist_cache().await;
}

let mut guard = self.cache.write().await;
let original_len = guard.len();
guard.retain(|tmdb_id, _| keep.contains(tmdb_id));

if guard.len() == original_len {
return Ok(());
}

drop(guard);
self.persist_cache().await
}

async fn cached_movie(&self, tmdb_id: i64) -> Option<RadarrMovie> {
let guard = self.cache.read().await;
guard.get(&tmdb_id).cloned()
Expand Down Expand Up @@ -348,61 +325,4 @@ mod tests {
assert_eq!(entry.title, "Spirited Away");
assert_eq!(entry.year, 2001);
}

#[tokio::test]
async fn retain_titles_clears_when_keep_empty() {
let dir = TempDir::new().unwrap();
let client = make_client(&dir);

client.store_movie(1, &movie("A", 2001)).await.unwrap();
client.store_movie(2, &movie("B", 2002)).await.unwrap();

client.retain_titles(&HashSet::new()).await.unwrap();

assert!(client.cached_movie(1).await.is_none());
assert!(client.cached_movie(2).await.is_none());
assert!(
load_cache(&dir.path().join(CACHE_FILENAME))
.unwrap()
.is_empty()
);
}

#[tokio::test]
async fn retain_titles_drops_unlisted_entries() {
let dir = TempDir::new().unwrap();
let client = make_client(&dir);

client.store_movie(1, &movie("A", 2001)).await.unwrap();
client.store_movie(2, &movie("B", 2002)).await.unwrap();
client.store_movie(3, &movie("C", 2003)).await.unwrap();

let keep: HashSet<i64> = [1, 3].into_iter().collect();
client.retain_titles(&keep).await.unwrap();

assert!(client.cached_movie(1).await.is_some());
assert!(client.cached_movie(2).await.is_none());
assert!(client.cached_movie(3).await.is_some());
}

#[tokio::test]
async fn retain_titles_skips_persist_when_unchanged() {
// Superset keep on populated cache: nothing removed, no rewrite expected.
let dir = TempDir::new().unwrap();
let client = make_client(&dir);
client.store_movie(1, &movie("A", 2001)).await.unwrap();

let cache_path = dir.path().join(CACHE_FILENAME);
std::fs::remove_file(&cache_path).unwrap();

let keep: HashSet<i64> = [1, 2].into_iter().collect();
client.retain_titles(&keep).await.unwrap();
assert!(!cache_path.exists());

// Empty keep on empty cache: same short-circuit.
let dir = TempDir::new().unwrap();
let client = make_client(&dir);
client.retain_titles(&HashSet::new()).await.unwrap();
assert!(!dir.path().join(CACHE_FILENAME).exists());
}
}
Loading
Loading