Doc(eslint-plugin-fiori-tools): update DataField rule documentation with semantic link information#4506
Conversation
🦋 Changeset detectedLatest commit: 88cd0d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/eslint-plugin-fiori-tools/docs/rules/sap-no-data-field-intent-based-navigation.md
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-fiori-tools/docs/rules/sap-no-data-field-intent-based-navigation.md
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-fiori-tools/docs/rules/sap-no-data-field-intent-based-navigation.md
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-fiori-tools/docs/rules/sap-no-data-field-intent-based-navigation.md
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-fiori-tools/docs/rules/sap-no-data-field-intent-based-navigation.md
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-fiori-tools/docs/rules/sap-no-data-field-intent-based-navigation.md
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-fiori-tools/docs/rules/sap-no-data-field-intent-based-navigation.md
Outdated
Show resolved
Hide resolved
…s/update-doc-for-semantic-link
|
@lfindlaysap Thanks, all text issues fixed in the latest commit. |
|
igorsVoronins
left a comment
igorsVoronins
left a comment
There was a problem hiding this comment.
Rule documentation update looks good ✅
marcovieth
left a comment
marcovieth
left a comment
There was a problem hiding this comment.
Looks good to me but please check the target...
|
|
||
| ```xml | ||
| <!-- Applied to the actual OData property, NOT inside DataField --> | ||
| <Annotation Term="Common.SemanticObject" String="Customer" Target="YourEntityType/CustomerId"/> |
There was a problem hiding this comment.
Can we set Target on Annotation?
Shouldn't we write the following?
<Annotations Target="YourEntityType/CustomerId">
<Annotation Term="Common.SemanticObject" String="Customer"/>
</Annotations>
There was a problem hiding this comment.
Hi @hitesh-parmar can you help with Marco's question?
4 participants
Rule documentation update.