Skip to content

feat: Extend add-new-model generator to support external services for CF projects#4523

Merged
mmilko01 merged 41 commits intomainfrom
feat/add-external-service-cf
Apr 15, 2026
Merged

feat: Extend add-new-model generator to support external services for CF projects#4523
mmilko01 merged 41 commits intomainfrom
feat/add-external-service-cf

Conversation

@mmilko01
Copy link
Copy Markdown
Contributor

@mmilko01 mmilko01 commented Apr 6, 2026

Feature for #4530

@mmilko01 mmilko01 self-assigned this Apr 6, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 6, 2026

🦋 Changeset detected

Latest commit: 7c21623

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@sap-ux/adp-tooling Patch
@sap-ux/generator-adp Patch
@sap-ux/create Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/backend-proxy-middleware-cf Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/deploy-config-sub-generator Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux-private/preview-middleware-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmilko01 mmilko01 marked this pull request as ready for review April 8, 2026 07:18
@mmilko01 mmilko01 requested review from a team as code owners April 8, 2026 07:18
@mmilko01 mmilko01 added create @sap-ux/create adp-tooling generator-adp @sap-ux/generator-adp feature New feature or request labels Apr 8, 2026
lfindlaysap
lfindlaysap previously approved these changes Apr 14, 2026
heimwege
heimwege previously approved these changes Apr 14, 2026
Copy link
Copy Markdown
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changeset ok
  • review comments addressed
  • did NOT test manually
  • coverage is ver good

@nikmace nikmace requested a review from lfindlaysap April 14, 2026 13:24
lfindlaysap
lfindlaysap previously approved these changes Apr 14, 2026
nikmace
nikmace previously approved these changes Apr 14, 2026
Copy link
Copy Markdown
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good
Coverage is good
Changeset is OK
Did not test manually

lfindlaysap
lfindlaysap previously approved these changes Apr 14, 2026
@kranthie-sap kranthie-sap dismissed stale reviews from lfindlaysap and nikmace via 67f96f6 April 14, 2026 14:23
@nikmace nikmace self-requested a review April 14, 2026 14:59
Copy link
Copy Markdown
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving ✅

@nikmace nikmace requested a review from heimwege April 14, 2026 14:59
Copy link
Copy Markdown
Contributor

@avasilev-sap avasilev-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Copy Markdown
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approve

@sonarqubecloud
Copy link
Copy Markdown

@mmilko01 mmilko01 merged commit 8fb08a2 into main Apr 15, 2026
18 checks passed
@mmilko01 mmilko01 deleted the feat/add-external-service-cf branch April 15, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adp-tooling create @sap-ux/create feature New feature or request generator-adp @sap-ux/generator-adp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants