feat: Serve merged manifest.json via proxy in CF ADP preview mode#4529
Open
feat: Serve merged manifest.json via proxy in CF ADP preview mode#4529
Conversation
🦋 Changeset detectedLatest commit: b0e153f The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feat for #4528.
setupCfBuildMode()now registers adp.proxy before serveStatic, so the proxy intercepts/manifest.json and Component-preload.js while static files are still served from the build
output.
initCfBuildMode()initializes mergedDescriptor from the build path manifest so thedescriptor getter works in CF mode.
sync()in CF mode triggers runBuild() with ADP_BUILDER_MODE=preview and re-reads themanifest from the build output.
proxy()in CF mode calls next() for non-manifest requests instead of attempting file-basedredirects (which caused redirect loops when mounted at /).