fix: remove duplicate keyframe definitions in animations.css (#740)#1235
Merged
SAPTARSHI-coder merged 2 commits intoJun 4, 2026
Merged
Conversation
…HI-coder#740) Remove '@Keyframes ease-kf-slide-image-exit', '@Keyframes ease-kf-shimmer-sweep', and '.ease-shimmer-sweep' from core/animations.css since they are already defined in the modular easemotion/ files (slide.css, hover.css, misc.css). This also fixes a CSS syntax error where .ease-shimmer-sweep was missing its closing brace, causing subsequent rules to be nested. Closes SAPTARSHI-coder#740
Contributor
📊 CSS Bundle Size BenchmarkThis PR changes the size of
|
Author
|
hey i fixed the assign issue so pls check thsi |
SAPTARSHI-coder
added
accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
@keyframes ease-kf-slide-image-exit,@keyframes ease-kf-shimmer-sweep, and.ease-shimmer-sweepfromcore/animations.css. These definitions are already present in the modulareasemotion/files (slide.css,hover.css,misc.css) where they belong — removing them from core eliminates duplication.This also fixes a CSS syntax error in
core/animations.csswhere the.ease-shimmer-sweepblock was missing its closing}, causing.ease-squish-button:hoverand.ease-gradient-rotationto be unintentionally nested inside it.Changes
core/animations.css— removed 4 blocks (2 keyframes + 2 classes), cleaned up whitespaceeasemotion.min.css— regenerated vianpm run buildCloses #740