EDADSlite Cuda support - #237
Open
Angelyr wants to merge 42 commits into
Open
Conversation
Conflicts: src/CMakeLists.txt
cherry picked from adityayjoshi/crv @ afa9729 with curved adapt changes removed
i really don't understand how separable compilation is supposed to work
bob_link_dependency requires Omega_h_USE_<depname> but here depname is not a tpl being enabled
doesn't output needed data
egads_lite_test now segfaults
is this a felony? without this change the call from EG_invEvaluate -> ... -> EG_invEvaGeomLimits fails
assumes the write_parallel was for debugging and not required for functionality
cwsmith
reviewed
Aug 30, 2026
| find_package(ADIOS2 REQUIRED) | ||
| endif() | ||
|
|
||
| if(Omega_h_USE_egadslite) |
There was a problem hiding this comment.
Does this support both the CPU and CUDA versions?
| } | ||
| } | ||
|
|
||
| printf("3.4\n"); |
| } | ||
|
|
||
| Reals egads_lite_get_snap_warp(Mesh* mesh, Egads* eg, bool verbose) { | ||
| fprintf(stderr, "numverts %d\n", mesh->nverts()); |
|
|
||
| Reals egads_lite_get_snap_warp(Mesh* mesh, Egads* eg, bool verbose) { | ||
| fprintf(stderr, "numverts %d\n", mesh->nverts()); | ||
| //Omega_h::vtk::write_parallel("preWarp", mesh, mesh->dim()); |
| auto setEdgeClass = OMEGA_H_LAMBDA(int i) { | ||
| if(edge_class_dims[i] == 1 && edge_class_ids_w[i] == 1) { | ||
| printf("edge %i reclassified\n",i); | ||
| edge_class_ids_w[i] = 7; |
There was a problem hiding this comment.
This may be a hack specific to the cone cone example. We may want to move this into a cone cone test case.
| auto eg = Omega_h::egads_lite_load(model_path); | ||
| Omega_h::egads_lite_reclassify(&mesh, eg); | ||
| opts.egads_model = eg; | ||
| Omega_h::hackClassification(&mesh); //there are problems... |
| void egads_lite_free(Egads* eg); | ||
| void egads_lite_reclassify(Mesh* mesh, Egads* eg); | ||
| Reals egads_lite_get_snap_warp(Mesh* mesh, Egads* eg, bool verbose); | ||
| void hackClassification(Omega_h::Mesh* mesh); |
There was a problem hiding this comment.
Can this be moved to a cone cone test case if we confirm that it is specific to that case?
| endif() | ||
|
|
||
| set(Omega_h_USE_egadslite_DEFAULT OFF) | ||
| bob_add_dependency(PUBLIC NAME egadslite TARGETS egadslite::egadslite) |
There was a problem hiding this comment.
We should prefix our egadslite branch as 'scorec-v####' and check for that version here; I don't think any of the other branches/versions will work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for egadsliteCuda
Including one test