chore: DAH-4277 cleaning up deprecated I2X code

[alulabeshue-sfgov]

Description

The sf-dahlia-backend has two sets of endpoints for sending I2X emails, /messages/invite-to-apply and /api/v1/message. The former API has been deprecated for the latter, in this ticket we clean up any code used to call /messages/invite-to-apply.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-4277

Before requesting eng review

Version Control

• branch name begins with angular if it contains updates to Angular code
• branch name contains the Jira ticket number
• PR name follows type: TICKET-NUMBER Description format, use DAH-000 if it does not need a ticket
• PR name follows urgent: Description format if it is urgent and does not need a ticket

Code quality

• the set of changes is small
• all automated code checks pass (linting, tests, coverage, etc.)
• if the PR is a bugfix, there are tests and logs around the bug

Code conventions

• web pages are formatted with .scss stylesheets and ui-seeds tokens, rather than inline styles or Tailwind

Review instructions

• instructions specify which environment(s) it applies to
• instructions work for PA testers
• instructions have already been performed at least once

Request eng review

• PR has needs review label
• Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
• If time sensitive, notify engineers in Slack

Before merging

Request product acceptance (PA) testing

• PA tested in the review environment (use needs product acceptance label)
• if PA testing cannot be done, changes are behind a feature flag

[Copilot]

Pull request overview

Removes deprecated Invite-to-Apply (I2A) / legacy I2X email-recording code paths and standardizes “invite to X” response recording on the /api/v1/message backend endpoint, with corresponding Rails + React + test updates.

Changes:

• Simplifies DahliaBackend::MessageService#send_invite_to_response to always post to /api/v1/message and removes deprecated endpoint mapping/field-building logic.
• Updates Rails controllers to send only (app_id, action) and removes the listingId requirement from the public record-response API.
• Updates React next-steps flows and Jest/RSpec coverage to match the new request shape/signatures.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
spec/services/dahlia_backend/message_service_spec.rb	Updates service specs for the new (app_id, action) contract and /api/v1/message payload.
spec/controllers/invite_to_controller_spec.rb	Updates controller spec expectations for the new send_invite_to_response signature.
spec/controllers/api/v1/invite_to_response_controller_spec.rb	Updates API controller specs to remove listingId from required record params.
app/services/dahlia_backend/message_service.rb	Removes deprecated I2A endpoint logic and standardizes I2X sending via /api/v1/message.
app/javascript/pages/inviteTo/inviteToInterview/InviteToInterviewNextSteps.tsx	Stops sending listingId in recordResponse calls; cleans up hook deps.
app/javascript/pages/inviteTo/inviteToApply/InviteToApplyNextSteps.tsx	Stops sending listingId in recordResponse calls.
app/javascript/modules/constants.tsx	Removes deprecated I2A_RESPONSES enum.
app/javascript/api/inviteToApiService.ts	Updates recordResponse type to drop listingId.
app/javascript/tests/pages/invite-to-interview.test.tsx	Updates tests to expect recordResponse without listingId.
app/javascript/tests/api/inviteToApiService.test.ts	Strengthens test to assert exact POST payload without listingId.
app/controllers/invite_to_controller.rb	Updates server-side recording to use (app_id, act) only and adjusts token preview encoding.
app/controllers/api/v1/invite_to_response_controller.rb	Removes listingId strong-param expectation/validation for record-response.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[cade-exygy]

LG!