Skip to content

feat: DAH-0000 Add custom employment & disability preference - #3036

Merged
cliu02 merged 1 commit into
mainfrom
DAH-0000-test-custom-preference
Aug 18, 2026
Merged

feat: DAH-0000 Add custom employment & disability preference#3036
cliu02 merged 1 commit into
mainfrom
DAH-0000-test-custom-preference

Conversation

@cliu02

@cliu02 cliu02 commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Description

Hotfix to add custom preference for Five88.

Jira ticket

https://sfgovdt.jira.com/browse/

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, use DAH-000 if it does not need a ticket
  • PR name follows urgent: Description format if it is urgent and does not need a ticket

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • if the PR is a bugfix, there are tests and logs around the bug

Code conventions

  • web pages are formatted with .scss stylesheets and ui-seeds tokens, rather than inline styles or Tailwind

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance (PA) testing

  • PA tested in the review environment (use needs product acceptance label)
  • if PA testing cannot be done, changes are behind a feature flag

@alulabeshue-sfgov
alulabeshue-sfgov temporarily deployed to dahlia-webap-dah-0000-t-ttj5af August 18, 2026 22:27 Inactive

@jimlin-sfgov jimlin-sfgov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cliu02
cliu02 marked this pull request as ready for review August 18, 2026 23:17
Copilot AI lite review requested due to automatic review settings August 18, 2026 23:17
@cliu02
cliu02 merged commit c1dd944 into main Aug 18, 2026
24 checks passed
@cliu02
cliu02 deleted the DAH-0000-test-custom-preference branch August 18, 2026 23:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hotfixes the short-form “custom preferences” flow by allowing an additional listing preference (“Employment or Disability Preference”) to appear on the e7b custom-preferences page, aligning the Angular custom-preference filtering with an already-supported preference type in the short-form components/translations.

Changes:

  • Add “Employment or Disability Preference” to the allowlist of custom preference names surfaced on the e7b custom-preferences page.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants