Fix legacy stake account migration after lock layout change#5
Draft
cursor[bot] wants to merge 2 commits into
Draft
Fix legacy stake account migration after lock layout change#5cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: PhiTapTrung67 <taihl.work@gmail.com>
Co-authored-by: PhiTapTrung67 <taihl.work@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Recent stake-lock changes added
locked_untildirectly toStakeAccount. Existing pre-lock stake PDAs used the old serialized layout, sodeposit_sol,withdraw_sol, andclaim_mentikcould fail during Anchor account deserialization before handlers ran. A user with SOL already staked before the redeploy could be unable to withdraw or claim.Root cause
Instruction account validation used
Account<StakeAccount>, which requires the current account layout. Old stake accounts were shorter by 8 bytes and could not be loaded.Fix
locked_until = 0) and resize/serialize them to the current layout on the next successful deposit, withdraw, or claim.system_programaccount.Validation
anchor build --ignore-keyscargo test -p mentik_sol_poolcargo test -p mentik-integration-tests(8 passed, including legacy migration tests)npm run build --prefix app