Replaced old wad/mip texture loading with imagelib in pxrad#274
Merged
SNMetamorph merged 1 commit intoSNMetamorph:masterfrom Jan 8, 2026
Merged
Conversation
a1batross
reviewed
Jan 8, 2026
|
|
||
| if( FS_FileExists( texpath, false )) | ||
| texture = Image_Quantize(texture); | ||
| miptex_t *newMip = static_cast<miptex_t*>(Mem_Alloc(sizeof(miptex_t) + ((texture->width * texture->height * 85) >> 6) + sizeof(short) + 768)); |
Contributor
There was a problem hiding this comment.
quantizing and then reconstructing mip back sounds like a hack but maybe it's fine for what it tries to do: use generic image loader
and Image_Quantize is going to be no-op for already indexed data.
the other parts of rad might not use miptex in the future and just use rgbdata_t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nuff said, i guess.