Update the shipped BlockConfig files to the current format - #110
Merged
Conversation
dmeoli
changed the title
davide-f
requested changes
Sep 1, 2026
davide-f
left a comment
davide-f
left a comment
Member
There was a problem hiding this comment.
Hello! Thanks, just a minor comment and then ready to merge with thanks!
| ### Minor Changes and Bug Fixes | ||
|
|
||
| * | ||
| * Update the shipped `BlockConfig` files to the current format: SMS++ now reads a version number after the differential flag and the structure `Configuration` first, so the shipped file was rejected, with the `-B` option silently having no effect. |
Member
There was a problem hiding this comment.
Please, add link to the PR: follow template
davide-f
approved these changes
Sep 2, 2026
davide-f
left a comment
davide-f
left a comment
Member
There was a problem hiding this comment.
Thanks! Approving and merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SMS++ changed the textual format of a
BlockConfig: after the differential flag it now reads a version number, and theConfigurationfor the structure comes first. The ten files shipped inpysmspp/data/configsare still in the old one, so SMS++ rejects each of them withand carries on without it, which means that passing them has had no effect at all: what they are there to select, the anchor constraints of a
TwoStageStochasticBlockor the network formulation of aDCNetworkBlock, was never applied.This updates all of them,
TSSBlock/TSSBCfg.txtand the nine underSDDPBlock/, leaving their content as it was: the only change is the version number and the empty structure slot. The result is textually identical to the same files as they are in the SMS++ test suite, which was converted when the format changed.Checked with the SMS++ tools: the error is gone for every one of them, the option is now actually read, and the optimum of a two-stage instance solved with
TSSBCfg.txtis unchanged.