Remove documentation build from CI verification and fix flaky test - #10
Conversation
Co-authored-by: miccy <9729864+miccy@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Fixes CI failures where scripts/typedoc-plugin-evolu.test.mts ran before TypeDoc-generated .mdx docs existed by ensuring docs are built as part of verify.
Changes:
- Updated the root
verifyscript to runbuild:docsbefore subsequent verification steps. - Ensures TypeDoc output exists before the TypeDoc plugin verification test executes.
| "lint-monorepo": "bunx sherif@latest", | ||
| "format": "biome format --write .", | ||
| "verify": "bun run format && bun run build && bun run test && bun run test:coverage && bun run lint && bun run lint-monorepo && bun vitest run scripts/typedoc-plugin-evolu.test.mts", | ||
| "verify": "bun run format && bun run build:docs && bun run build && bun run test && bun run test:coverage && bun run lint && bun run lint-monorepo && bun vitest run scripts/typedoc-plugin-evolu.test.mts", |
There was a problem hiding this comment.
build:docs is only required for the final typedoc plugin verification test; running it immediately after format means CI will spend time generating docs even if build/test/lint later fail. Consider moving bun run build:docs to just before bun vitest run scripts/typedoc-plugin-evolu.test.mts to keep the same correctness while reducing wasted CI time on failing runs.
| "verify": "bun run format && bun run build:docs && bun run build && bun run test && bun run test:coverage && bun run lint && bun run lint-monorepo && bun vitest run scripts/typedoc-plugin-evolu.test.mts", | |
| "verify": "bun run format && bun run build && bun run test && bun run test:coverage && bun run lint && bun run lint-monorepo && bun run build:docs && bun vitest run scripts/typedoc-plugin-evolu.test.mts", |
|
Nepotřebujeme build dokumentace. V dalších PR bude přesunuta mimo monorepo. @copilot vypni build docs a zajisti ať to kvuli tomu nefailuje |
Co-authored-by: miccy <9729864+miccy@users.noreply.github.com>
Fixed in commit d62c245. Removed both |
|
@copilot CI znovu fail. Zjisti chybu a udělej fix |
Co-authored-by: miccy <9729864+miccy@users.noreply.github.com>
Co-authored-by: miccy <9729864+miccy@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
Documentation build is being removed from CI verification as it will be moved outside the monorepo in future PRs.
Changes:
build:docsfrom theverifyscript inpackage.jsonscripts/typedoc-plugin-evolu.test.mtstest from verification (requires generated docs)packages/common/test/local-first/Protocol.test.tsby increasing timeout from 5s to 15s for the "client and relay each have a random half of the data" E2E sync testformat→build→test→test:coverage→lint→lint-monorepoWhy package.json:
The
.github/workflows/ci.yamlfile is protected by repository rules, so changes were applied to the verify script itself.This streamlines CI by removing documentation generation and tests that depend on it, while also addressing a flaky test that was causing CI failures in slower environments.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.